sapling/phabricator
Adam Simpkins 36dcf86559 phabstatus: fail gracefully if necessary arcrc settings are missing
Summary:
If the user does not have necesary credentials defined in their arc
configuration, catch the KeyError and convert it into an ArcConfigError.

The existing call sites in the phabstatus and arcdiff extensions catch and
handle ArcConfigError, but not generic KeyErrors.

This also fixes the phabstatus warning messages to end with a newline.

Test Plan: Added a unit test.

Reviewers: #sourcecontrol, quark, simonfar, wez, rmcelroy

Reviewed By: wez, rmcelroy

Subscribers: rmcelroy, net-systems-diffs@fb.com, yogeshwer, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D4800977

Tasks: 17002914

Signature: t1:4800977:1490847078:e18bba042e3ff57100e0a7b25c610b5cad17fa2e
2017-03-30 11:55:39 -07:00
..
__init__.py add arcconfig accessors 2016-04-27 09:27:56 -07:00
arcconfig.py add arcconfig accessors 2016-04-27 09:27:56 -07:00
conduit.py phabstatus: fail gracefully if necessary arcrc settings are missing 2017-03-30 11:55:39 -07:00
diffprops.py phabdiff: only match at the start of a line 2017-03-28 20:53:07 -07:00