mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 09:17:30 +03:00
9dc21f8d0b
Summary: D13853115 adds `edenscm/` to `sys.path` and code still uses `import mercurial`. That has nasty problems if both `import mercurial` and `import edenscm.mercurial` are used, because Python would think `mercurial.foo` and `edenscm.mercurial.foo` are different modules so code like `try: ... except mercurial.error.Foo: ...`, or `isinstance(x, mercurial.foo.Bar)` would fail to handle the `edenscm.mercurial` version. There are also some module-level states (ex. `extensions._extensions`) that would cause trouble if they have multiple versions in a single process. Change imports to use the `edenscm` so ideally the `mercurial` is no longer imported at all. Add checks in extensions.py to catch unexpected extensions importing modules from the old (wrong) locations when running tests. Reviewed By: phillco Differential Revision: D13868981 fbshipit-source-id: f4e2513766957fd81d85407994f7521a08e4de48
114 lines
2.8 KiB
Perl
114 lines
2.8 KiB
Perl
Test the extensions.afterloaded() function
|
|
|
|
$ cat > foo.py <<EOF
|
|
> from edenscm.mercurial import extensions
|
|
> def uisetup(ui):
|
|
> ui.write("foo.uisetup\\n")
|
|
> ui.flush()
|
|
> def bar_loaded(loaded):
|
|
> ui.write("foo: bar loaded: %r\\n" % (loaded,))
|
|
> ui.flush()
|
|
> extensions.afterloaded('bar', bar_loaded)
|
|
> EOF
|
|
$ cat > bar.py <<EOF
|
|
> def uisetup(ui):
|
|
> ui.write("bar.uisetup\\n")
|
|
> ui.flush()
|
|
> EOF
|
|
$ basepath=`pwd`
|
|
|
|
$ hg init basic
|
|
$ cd basic
|
|
$ echo foo > file
|
|
$ hg add file
|
|
$ hg commit -m 'add file'
|
|
|
|
$ echo '[extensions]' >> .hg/hgrc
|
|
$ echo "foo = $basepath/foo.py" >> .hg/hgrc
|
|
$ echo "bar = $basepath/bar.py" >> .hg/hgrc
|
|
$ hg log -r. -T'{rev}\n'
|
|
foo.uisetup
|
|
foo: bar loaded: True
|
|
bar.uisetup
|
|
0
|
|
|
|
Test afterloaded with the opposite extension load order
|
|
|
|
$ cd ..
|
|
$ hg init basic_reverse
|
|
$ cd basic_reverse
|
|
$ echo foo > file
|
|
$ hg add file
|
|
$ hg commit -m 'add file'
|
|
|
|
$ echo '[extensions]' >> .hg/hgrc
|
|
$ echo "bar = $basepath/bar.py" >> .hg/hgrc
|
|
$ echo "foo = $basepath/foo.py" >> .hg/hgrc
|
|
$ hg log -r. -T'{rev}\n'
|
|
bar.uisetup
|
|
foo.uisetup
|
|
foo: bar loaded: True
|
|
0
|
|
|
|
Test the extensions.afterloaded() function when the requested extension is not
|
|
loaded
|
|
|
|
$ cd ..
|
|
$ hg init notloaded
|
|
$ cd notloaded
|
|
$ echo foo > file
|
|
$ hg add file
|
|
$ hg commit -m 'add file'
|
|
|
|
$ echo '[extensions]' >> .hg/hgrc
|
|
$ echo "foo = $basepath/foo.py" >> .hg/hgrc
|
|
$ hg log -r. -T'{rev}\n'
|
|
foo.uisetup
|
|
foo: bar loaded: False
|
|
0
|
|
|
|
Test the extensions.afterloaded() function when the requested extension is not
|
|
configured but fails the minimum version check
|
|
|
|
$ cd ..
|
|
$ cat > minvers.py <<EOF
|
|
> minimumhgversion = '9999.9999'
|
|
> def uisetup(ui):
|
|
> ui.write("minvers.uisetup\\n")
|
|
> ui.flush()
|
|
> EOF
|
|
$ hg init minversion
|
|
$ cd minversion
|
|
$ echo foo > file
|
|
$ hg add file
|
|
$ hg commit -m 'add file'
|
|
|
|
$ echo '[extensions]' >> .hg/hgrc
|
|
$ echo "foo = $basepath/foo.py" >> .hg/hgrc
|
|
$ echo "bar = $basepath/minvers.py" >> .hg/hgrc
|
|
$ hg log -r. -T'{rev}\n'
|
|
(third party extension bar requires version 9999.9999 or newer of Mercurial; disabling)
|
|
foo.uisetup
|
|
foo: bar loaded: False
|
|
0
|
|
|
|
Test the extensions.afterloaded() function when the requested extension is not
|
|
configured but fails the minimum version check, using the opposite load order
|
|
for the two extensions.
|
|
|
|
$ cd ..
|
|
$ hg init minversion_reverse
|
|
$ cd minversion_reverse
|
|
$ echo foo > file
|
|
$ hg add file
|
|
$ hg commit -m 'add file'
|
|
|
|
$ echo '[extensions]' >> .hg/hgrc
|
|
$ echo "bar = $basepath/minvers.py" >> .hg/hgrc
|
|
$ echo "foo = $basepath/foo.py" >> .hg/hgrc
|
|
$ hg log -r. -T'{rev}\n'
|
|
(third party extension bar requires version 9999.9999 or newer of Mercurial; disabling)
|
|
foo.uisetup
|
|
foo: bar loaded: False
|
|
0
|