mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 09:17:30 +03:00
9dc21f8d0b
Summary: D13853115 adds `edenscm/` to `sys.path` and code still uses `import mercurial`. That has nasty problems if both `import mercurial` and `import edenscm.mercurial` are used, because Python would think `mercurial.foo` and `edenscm.mercurial.foo` are different modules so code like `try: ... except mercurial.error.Foo: ...`, or `isinstance(x, mercurial.foo.Bar)` would fail to handle the `edenscm.mercurial` version. There are also some module-level states (ex. `extensions._extensions`) that would cause trouble if they have multiple versions in a single process. Change imports to use the `edenscm` so ideally the `mercurial` is no longer imported at all. Add checks in extensions.py to catch unexpected extensions importing modules from the old (wrong) locations when running tests. Reviewed By: phillco Differential Revision: D13868981 fbshipit-source-id: f4e2513766957fd81d85407994f7521a08e4de48
69 lines
1.9 KiB
Perl
69 lines
1.9 KiB
Perl
Tests the behavior of the DEFAULT_EXTENSIONS constant in extensions.py
|
|
|
|
$ hg init a
|
|
$ cd a
|
|
|
|
hg githelp works without enabling:
|
|
|
|
$ hg githelp -- git reset HEAD
|
|
hg reset .
|
|
|
|
Behaves identically if enabled manually:
|
|
|
|
$ hg githelp --config extensions.githelp= -- git reset HEAD
|
|
hg reset .
|
|
|
|
Not if turned off:
|
|
(note: extension discovery only works for normal layout)
|
|
|
|
#if normal-layout
|
|
$ hg githelp --config extensions.githelp=! -- git reset HEAD
|
|
hg: unknown command 'githelp'
|
|
'githelp' is provided by the following extension:
|
|
|
|
githelp try mapping git commands to Mercurial commands
|
|
|
|
(use 'hg help extensions' for information on enabling extensions)
|
|
[255]
|
|
#endif
|
|
|
|
Or overriden by a different path:
|
|
|
|
$ cat > githelp2.py <<EOF
|
|
> from __future__ import absolute_import
|
|
> from edenscm.mercurial import registrar
|
|
>
|
|
> cmdtable = {}
|
|
> command = registrar.command(cmdtable)
|
|
>
|
|
> @command('githelp')
|
|
> def githhelp(ui, repo, *args, **opts):
|
|
> ui.warn('Custom version of hg githelp\n')
|
|
>
|
|
> EOF
|
|
$ hg githelp --config extensions.githelp=`pwd`/githelp2.py -- git reset HEAD
|
|
Custom version of hg githelp
|
|
|
|
A default extension's reposetup and extsetup are run:
|
|
$ cd $TESTTMP
|
|
$ mkdir hgext
|
|
$ cat > hgext/mofunc.py <<EOF
|
|
> from edenscm.hgext import githelp
|
|
> def extsetup(ui):
|
|
> # Only print reposetup() once so that this test output doesn't change
|
|
> # the number of times repo gets wrapped as we enable extensions.
|
|
> githelp.reposetupcount = 0
|
|
> def reposetup(ui, repo):
|
|
> if githelp.reposetupcount == 0:
|
|
> ui.warn('githelp reposetup()\n')
|
|
> githelp.reposetupcount += 1
|
|
> def extsetup(ui):
|
|
> ui.warn('githelp extsetup()\n')
|
|
> githelp.reposetup = reposetup
|
|
> githelp.extsetup = extsetup
|
|
> EOF
|
|
$ hg -R a githelp --config extensions.path=hgext/mofunc.py -- git status
|
|
githelp extsetup()
|
|
githelp reposetup()
|
|
hg status
|