facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-12 09:48:05 +03:00
Code Issues Projects Releases Wiki Activity
9277617d1e
sapling/edenscm/hgext/extlib
History
Zeyi Fan 9277617d1e fix double free in cdatapack 
Summary:
Mercurial recently started to generate empty pack files (`0x01`). This will cause this check to fail:

diffusion/FBS/browse/master/fbcode/scm/hg/lib/cdatapack/cdatapack.c;2c4197d003ed906dd8eaf70fbb04aa53440ce681$314-319

This will subsequently result as a double-free error between these two:

**In `error_cleanup`**

diffusion/FBS/browse/master/fbcode/scm/hg/lib/cdatapack/cdatapack.c;2c4197d003ed906dd8eaf70fbb04aa53440ce681$387-389

**In `close_datapack`**

diffusion/FBS/browse/master/fbcode/scm/hg/lib/cdatapack/cdatapack.c;2c4197d003ed906dd8eaf70fbb04aa53440ce681$401

This diff will fix this bug.

Differential Revision: D14759374

fbshipit-source-id: 06f192513a935740c2142b5a2baac87a28903496
2019-04-03 21:13:13 -07:00
..
cfastmanifest codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
cstore fix double free in cdatapack 2019-04-03 21:13:13 -07:00
ctreemanifest codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
indexes build: remove profile.lto setting from crates in workspace 2019-03-25 16:38:41 -07:00
phabricator migrate to use new names in scm/hg/edenscm 2019-04-02 23:34:04 -07:00
pyrevisionstore remotefilelog: handle missing packfiles properly 2019-03-28 10:24:29 -07:00
pywatchman watchman: canonicalize repo root before querying watchman 2019-02-04 10:34:08 -08:00
watchmanclient watchman: canonicalize repo root before querying watchman 2019-02-04 10:34:08 -08:00
__init__.py codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
Cargo.toml extlib: add cargo workspace 2019-03-20 19:56:14 -07:00
cfastmanifest.c codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
linelog.pyx codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
litemmap.pyx codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
mysqlutil.py codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
README.md codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00
traceprofimpl.cpp codemod: move Python packages to edenscm 2019-01-28 18:35:41 -08:00

README.md

extlib

Code that extensions depend on, but aren't themselves extensions, should go here. Both native (C/C++/Cython/Rust) and Python code is allowed. Code that depends on Python is also allowed.

In theory, this code should slowly disappear as extension code gets folded into mainline Mercurial. (The native bits should go into lib/ or mercurial/cext), the Python code into mercurial/ itself.)

See also lib/README.md, mercurial/cext/README.md.