mirror of
https://github.com/facebook/sapling.git
synced 2024-10-12 09:48:05 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
81 lines
2.1 KiB
Python
81 lines
2.1 KiB
Python
# hint.py - utilities to register hint messages
|
|
#
|
|
# Copyright 2018 Facebook Inc.
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2 or any later version.
|
|
|
|
from __future__ import absolute_import
|
|
|
|
from . import rcutil, util
|
|
from .i18n import _
|
|
|
|
|
|
hinttable = {}
|
|
messages = []
|
|
triggered = set()
|
|
|
|
|
|
def loadhint(ui, extname, registrarobj):
|
|
for name, func in registrarobj._table.iteritems():
|
|
hinttable[name] = func
|
|
|
|
|
|
def loadhintconfig(ui):
|
|
for name, message in ui.configitems("hint-definitions"):
|
|
hinttable[name] = lambda *args, **kwargs: message
|
|
|
|
|
|
def trigger(name, *args, **kwargs):
|
|
"""Trigger a hint message. It will be shown at the end of the command."""
|
|
func = hinttable.get(name)
|
|
if func and name not in triggered:
|
|
triggered.add(name)
|
|
msg = func(*args, **kwargs)
|
|
if msg:
|
|
messages.append((name, msg.rstrip()))
|
|
|
|
|
|
def _prefix(ui, name):
|
|
"""Return "hint[%s]" % name, colored"""
|
|
return ui.label(_("hint[%s]: ") % (name,), "hint.prefix")
|
|
|
|
|
|
def show(ui):
|
|
"""Show all triggered hint messages"""
|
|
if ui.plain("hint"):
|
|
return
|
|
acked = ui.configlist("hint", "ack")
|
|
if acked == ["*"]:
|
|
|
|
def isacked(name):
|
|
return True
|
|
|
|
else:
|
|
acked = set(acked)
|
|
|
|
def isacked(name):
|
|
return name in acked or ui.configbool("hint", "ack-%s" % name)
|
|
|
|
names = []
|
|
for name, msg in messages:
|
|
if not isacked(name):
|
|
prefix = _prefix(ui, name)
|
|
ui.write_err(("%s%s\n") % (prefix, msg.rstrip()))
|
|
names.append(name)
|
|
if names and not isacked("hint-ack"):
|
|
prefix = _prefix(ui, "hint-ack")
|
|
msg = _("use 'hg hint --ack %s' to silence these hints\n") % " ".join(names)
|
|
ui.write_err(prefix + msg)
|
|
|
|
|
|
def silence(ui, names):
|
|
"""Silence given hints"""
|
|
path = rcutil.userrcpath()[0]
|
|
acked = ui.configlist("hint", "ack")
|
|
for name in names:
|
|
if name not in acked:
|
|
acked.append(name)
|
|
value = " ".join(util.shellquote(w) for w in acked)
|
|
rcutil.editconfig(path, "hint", "ack", value)
|