mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 08:47:12 +03:00
99511f8743
Summary: Change dag_ops benchmarks to use different IdDagStores. An example run shows: benchmarking dag::iddagstore::indexedlog_store::IndexedLogStore building segments (old) 856.803 ms building segments (new) 127.831 ms ancestors 54.288 ms children (spans) 619.966 ms children (1 id) 12.596 ms common_ancestors (spans) 3.050 s descendants (small subset) 35.652 ms gca_one (2 ids) 164.296 ms gca_one (spans) 3.132 s gca_all (2 ids) 270.542 ms gca_all (spans) 2.817 s heads 247.504 ms heads_ancestors 40.106 ms is_ancestor 108.719 ms parents 243.317 ms parent_ids 10.752 ms range (2 ids) 7.370 ms range (spans) 23.933 ms roots 620.150 ms benchmarking dag::iddagstore::in_process_store::InProcessStore building segments (old) 790.429 ms building segments (new) 55.007 ms ancestors 8.618 ms children (spans) 196.562 ms children (1 id) 2.488 ms common_ancestors (spans) 545.344 ms descendants (small subset) 8.093 ms gca_one (2 ids) 24.569 ms gca_one (spans) 529.080 ms gca_all (2 ids) 38.462 ms gca_all (spans) 540.486 ms heads 103.930 ms heads_ancestors 6.763 ms is_ancestor 16.208 ms parents 103.889 ms parent_ids 0.822 ms range (2 ids) 1.748 ms range (spans) 6.157 ms roots 197.924 ms benchmarking dag::iddagstore::bytes_store::BytesStore building segments (old) 724.467 ms building segments (new) 90.207 ms ancestors 23.812 ms children (spans) 348.237 ms children (1 id) 4.609 ms common_ancestors (spans) 1.315 s descendants (small subset) 20.819 ms gca_one (2 ids) 72.423 ms gca_one (spans) 1.346 s gca_all (2 ids) 116.025 ms gca_all (spans) 1.470 s heads 155.667 ms heads_ancestors 19.486 ms is_ancestor 51.529 ms parents 157.285 ms parent_ids 5.427 ms range (2 ids) 4.448 ms range (spans) 13.874 ms roots 365.568 ms Overall, InProcessStore > BytesStore > IndexedLogStore. The InProcessStore uses `Vec<BTreeMap<Id, StoreId>>` for the level-head index, which is more efficient on the "Level" lookup (Vec), and more cache efficient (BTree). BytesStore outperforms IndexedLogStore because it does not need to verify checksum on every read access - the checksum was verified at store creation (IdDag::from_bytes). Note: The `BytesStore` is something optimized for serialization, and hasn't been sent. Reviewed By: sfilipco Differential Revision: D23438174 fbshipit-source-id: 6e5f15188e3b935659ccde25fac573e9b963b78f |
||
|---|---|---|
| .. | ||
| async-runtime | ||
| auth | ||
| backingstore | ||
| blackbox | ||
| bookmarkstore | ||
| cdatapack | ||
| clib | ||
| clidispatch | ||
| cliparser | ||
| commitcloudsubscriber | ||
| commitstore/bench-serialize | ||
| configparser | ||
| cpython-ext | ||
| dag | ||
| dev-logger | ||
| drawdag | ||
| edenapi | ||
| edenfs-client | ||
| encoding | ||
| fsinfo | ||
| fsyncglob | ||
| hgcommands | ||
| hgcommits | ||
| hgtime | ||
| http_client | ||
| indexedlog | ||
| linelog | ||
| lz4-pyframe | ||
| manifest | ||
| manifest-tree | ||
| metalog | ||
| mincode | ||
| minibench | ||
| minibytes | ||
| mpatch | ||
| mpatch-sys | ||
| mutationstore | ||
| nodemap | ||
| pathmatcher | ||
| procinfo | ||
| radixbuf | ||
| renderdag | ||
| revisionstore | ||
| revlogindex | ||
| spawn-ext | ||
| taggederror | ||
| taggederror-util | ||
| third-party | ||
| thrift-types | ||
| tracing-collector | ||
| treestate | ||
| types | ||
| util | ||
| version | ||
| vfs | ||
| vlqencoding | ||
| workingcopy | ||
| xdiff | ||
| xdiff-sys | ||
| zstdelta | ||
| zstore | ||
| CMakeLists.txt | ||
| README.md | ||
lib
Any native code (C/C++/Rust) that Mercurial (either core or extensions)
depends on should go here. Python code, or native code that depends on
Python code (e.g. #include <Python.h> or use cpython) is disallowed.
As we start to convert more of Mercurial into Rust, and write new paths entrirely in native code, we'll want to limit our dependency on Python, which is why this barrier exists.
See also hgext/extlib/README.md, mercurial/cext/README.mb.
How do I choose between lib and extlib (and cext)?
If your code is native and doesn't depend on Python (awesome!), it goes here.
Otherwise, put it in hgext/extlib (if it's only used by extensions) or
mercurial/cext (if it's used by extensions or core).