sapling/eden/fs/takeover
Adam Simpkins e07f8bd7b6 refactor the EDEN_BUG() macro
Summary:
This splits `EDEN_BUG()` into three separate version.  All three crash in
debug mode builds, but in release builds they behave differently:

- `EDEN_BUG()` throws an exception
- `EDEN_BUG_FUTURE(Type)` returns a `folly::Future<Type>` that has been
  fulfilled with an exception.
- `EDEN_BUG_EXCEPTION()` returns a `folly::exception_wrapper`.

The main advantage of this is that this allows the compiler to detect that
`EDEN_BUG()` can never return.  Previously `EDEN_BUG()` was used for all 3 of
these different cases, and its behavior depended on whether `toException()`
was ever called.  As a result we could not easily get the compiler to identify
code paths where we know at compile time that it will never return.

Reviewed By: chadaustin

Differential Revision: D18652103

fbshipit-source-id: 070107c7520f51b05696905fa243de5f8df15958
2019-11-22 15:38:33 -08:00
..
test Tidy up license headers 2019-10-11 05:28:23 -07:00
CMakeLists.txt fbcode_builder: rename add_thrift_cpp2_library() to add_fbthrift_cpp_library() 2019-08-29 16:45:12 -07:00
takeover.thrift Tidy up license headers 2019-10-11 05:28:23 -07:00
TakeoverClient.cpp Remove dead includes in eden 2019-10-11 16:45:01 -07:00
TakeoverClient.h Tidy up license headers 2019-10-11 05:28:23 -07:00
TakeoverData.cpp refactor the EDEN_BUG() macro 2019-11-22 15:38:33 -08:00
TakeoverData.h Tidy up license headers 2019-10-11 05:28:23 -07:00
TakeoverHandler.h Tidy up license headers 2019-10-11 05:28:23 -07:00
TakeoverServer.cpp clang-format 2019-10-24 14:56:43 -07:00
TakeoverServer.h Tidy up license headers 2019-10-11 05:28:23 -07:00