A Scalable, User-Friendly Source Control System.
Go to file
Adam Simpkins 9d76f8392d remotefilelog: don't define a sparsematch() method
Summary:
The remotefilelog extension previously unconditionally added a sparsematch()
method to repository objects, which just called super.sparsematch() if this is
a sparse repository, and returned None if this isn't a sparse repository.

However, defining a sparsematch() method that returns None confuses the sparse
extension.  The sparse extension expects that all repositories that define
sparesmatch() are actually sparse repositories, and never expects this method
to return null.

This updates the remotefilelog code to call its method maybesparsematch()
instead.

Test Plan:
Confirmed existing remotefilelog unit tests pass, and that the sparse extension
no longer crashes when it is used with non-sparse repositories.  (This happens
when using the share extension, if the current working directory is non-sparse
but the sharedpath repository configuration loads the sparse extension.)

Reviewers: tja, durham

Reviewed By: durham

Subscribers: net-systems-diffs@, yogeshwer, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D4466108

Signature: t1:4466108:1485451483:287a519151e35bdb99f5be0d9287b4698386183e
2017-01-26 11:01:31 -08:00
cdatapack cdatapack: include sys/types.h for off_t 2016-11-28 17:24:45 -05:00
cfastmanifest port upgrades of buffer.h into clib 2016-08-26 17:14:52 -07:00
clib port upgrades of buffer.h into clib 2016-08-26 17:14:52 -07:00
contrib debian: Do not package hgext3rd/__init__.py 2016-12-19 16:34:49 -08:00
ctreemanifest ctreemanifest: make find() throw KeyError 2017-01-13 09:42:39 -08:00
fastannotate fastannotate: work better with remotefilelog 2016-12-19 12:13:51 -08:00
fastmanifest fastmanifest: use repo ui for new manifests 2017-01-25 15:18:40 -08:00
hgext3rd allowunstable: allow hg record in the middle of a stack 2017-01-26 10:24:16 -08:00
infinitepush infinitepush: add locktimeout 2017-01-24 10:32:44 -08:00
linelog linelog: add some text about differences with revlog in README 2016-11-18 02:34:06 +00:00
phabricator phabdiff: precompile regexes 2017-01-09 01:37:48 -08:00
remotefilelog remotefilelog: don't define a sparsematch() method 2017-01-26 11:01:31 -08:00
scripts unittests: drop special casing of lz4revlog extension 2017-01-19 12:58:38 -08:00
sqldirstate testedwith: change testedwith to "ships-with-fb-hgext" 2016-11-29 13:24:07 +00:00
tests allowunstable: allow hg record in the middle of a stack 2017-01-26 10:24:16 -08:00
treemanifest treemanifest: error out if invalid configuration 2017-01-13 14:58:20 -08:00
.editorconfig Add editorconfig 2016-04-20 03:05:42 -07:00
.hgignore arc: implement an arcanist unittest engine for mercurial 2016-09-19 22:41:58 +01:00
cfastmanifest.c [cfastmanifest] add PyObject_Del to dealloc method 2016-08-09 13:47:49 -07:00
CMakeLists.txt Move ctreemanifest and cdatapack out of remotefilelog 2016-09-21 13:55:12 -07:00
COPYING Initial commit with extensions and readme 2014-06-02 12:54:54 -07:00
Makefile merge Makefile contents 2016-08-26 06:27:59 -07:00
README.md rewrite intro paragraph to README.md 2016-08-26 08:46:48 -07:00
setup.py Change setup.py to build modules for windows 2016-12-13 17:20:13 -08:00
statprof.py Added additional flags to statprof.py 2016-10-17 18:49:22 -07:00

fb-hgext

This is a collection of Mercurial extensions written at Facebook. Many of them are in heavy use by thousands of users on a daily basis. However, some of them are very specific to Facebook's very large repositories so their value to others will vary. We're still making these open source as examples of the workflows we use and direction we are working.

Note that there will be extensions included here that only work with Facebook's internal infrastructure; they are included to give you an idea of how we integrate mercurial with our workflows.

Below are snippets about some of the extensions contained here.

smartlog

An extension that adds the 'hg smartlog' command. It prints graph log output containing only the commits relevant to yourself. Shows your bookmarks, the @ or master bookmark, and any draft commits without bookmarks that you've made within the past 2 weeks. Any commits in the graph that are skipped are represented by '...'.

We recommend also having an 'hg sl' alias that gives more concise output:

alias.sl=smartlog --template "{shortest(node)}  {author|user}  {bookmarks % '{ifeq(bookmark, current, label(\"yellow\", \" {bookmark}*\"), label(\"green\", \" {bookmark}\"))}'} {ifeq(branch, 'default', '', label(\"bold\", branch))}\n{desc|firstline}\n\n"

githelp

An extension that adds the 'hg githelp' command. It translates Git commands into Mercurial commands. Example:

$ hg githelp -- git rebase origin/master
  hg rebase -d master

$ hg githelp -- reset --hard HEAD^
  hg strip -r .

So it acts as a useful cheat sheet tool for people moving from Git to Mercurial.

backups

An extension that adds the 'hg backups' command. 'hg backups' prints a list of recently deleted commits (by reading your .hg/strip-backups directory) and allows you to recover a commit by doing 'hg backups --recover '. It prints the missing commits in reverse chronological order, and acts as a pseudo-replacement for Git's reflog.

fbamend

An extension that adds the 'hg amend --rebase' command. When working with a stack of commits, it's currently impossible to amend a commit in the middle of the stack. This extension enables that ability, adds a 'hg amend' command that invokes 'hg commit --amend', and adds a --rebase flag to 'hg amend --rebase' that rebase all the children of the commit onto the newly amended version.

If 'hg amend' is run on a commit in the middle of a stack without using --rebase, the amend succeeds and the old version of the commit is left behind with a marker bookmark on it 'bookmarkname(preamend)'. The user can then run 'hg amend --fixup' to post-humously rebase the children onto the new version of the commit.

uncommit

Adds a 'hg uncommit' command, which undoes the effect of a local commit. This allows you to either undo a mistake, or remove files from a commit which weren't intended for it.

By default it uncommits all the files, and completely hides the changeset. However, if filenames are specified then it will create a new changeset excluding those files and leave the files in a dirty state in the working dir. In all cases, files are left unchanged in the working dir, so other local changes are unaffected.

Uncommit does work in the middle of a stack of changes (possibly creating a new head), but cannot be used to undo a merge changeset.

chistedit

An interactive ncurses interface to histedit.

NOTE: This requires python-curses installed and Mercurial's histedit extension enabled.

This extensions allows you to interactively move around changesets or change the action to perform while keeping track of possible conflicts.

upgradegeneraldelta

Upgrades manifests to generaldelta in-place, without needing to reclone.

Contributing

Patches are welcome as pull requests, though they will be collapsed and rebased to maintain a linear history.

We (Facebook) have to ask for a "Contributor License Agreement" from someone who sends in a patch or code that we want to include in the codebase. This is a legal requirement; a similar situation applies to Apache and other ASF projects.

If we ask you to fill out a CLA we'll direct you to our online CLA page where you can complete it easily. We use the same form as the Apache CLA so that friction is minimal.

License

These extensions are made available under the terms of the GNU General Public License version 2, or any later version. See the COPYING file that accompanies this distribution for the full text of the license.