mirror of
https://github.com/facebook/sapling.git
synced 2024-10-04 22:07:44 +03:00
a304281786
Summary: github: migrate docker from deprecated nodesource script, fixes 60 second delay nodesource have added a 60 second delay in their setup_XX scripts to encourage people to move to reference their apt repo directly. update the docker file, as I found the 60 second delay annoying when adding the gh cli to the image in the next change Pull Request resolved: https://github.com/facebook/sapling/pull/728 Test Plan: Run a build ``` docker build -t sapling-cli-ubuntu-22.04 -f .github/workflows/sapling-cli-ubuntu-22.04.Dockerfile . ``` Before, get the 60 second wait message from the nodesource script ``` --> 657ed25e358a STEP 6/17: RUN curl -fsSL https://deb.nodesource.com/setup_16.x | bash - ================================================================================ ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ ================================================================================ SCRIPT DEPRECATION WARNING This script, located at https://deb.nodesource.com/setup_X, used to install Node.js is deprecated now and will eventually be made inactive. Please visit the NodeSource distributions Github and follow the instructions to migrate your repo. https://github.com/nodesource/distributions The NodeSource Node.js Linux distributions GitHub repository contains information about which versions of Node.js and which Linux distributions are supported and how to install it. https://github.com/nodesource/distributions SCRIPT DEPRECATION WARNING ================================================================================ ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ ================================================================================ TO AVOID THIS WAIT MIGRATE THE SCRIPT Continuing in 60 seconds (press Ctrl-C to abort) ... ``` After, the 60 second wait has gone --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/728). * https://github.com/facebook/sapling/issues/729 * __->__ https://github.com/facebook/sapling/issues/728 Reviewed By: sggutier Differential Revision: D50088155 Pulled By: genevievehelsel fbshipit-source-id: 2bf1d9c842eeebf579588f0d67623aa39ea5c881 |
||
|---|---|---|
| .. | ||
| workflows | ||