mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 15:27:13 +03:00
73eac46994
Summary: We have seen issues that users have outdated groups when running hg commands, which will probably always cause issues: - Authentication issue, unable to ssh - Filesystem permission issue, unable to write hgcache - Even worse with chg server since the long-running server process will keep the wrong groups information This extension is to address the above issues. It allows us to print a message to let the user know they have group issues. Besides, it allows us to override configs like `chgserver.idletimeout` so chg servers with wrong groups can have a much smaller TTL and won't be long-running and causing issues. Test Plan: Run the newly added test Reviewers: #sourcecontrol, simonfar Reviewed By: simonfar Subscribers: simonfar, mjpieters Differential Revision: https://phabricator.intern.facebook.com/D3896628 Signature: t1:3896628:1474454162:22785ff23e3ada75013ce5f1eead3407068ba172
74 lines
1.6 KiB
Perl
74 lines
1.6 KiB
Perl
$ cat >> $HGRCPATH << EOF
|
|
> [extensions]
|
|
> grpcheck = $TESTDIR/../hgext3rd/grpcheck.py
|
|
> EOF
|
|
|
|
$ hg init repo
|
|
$ cd repo
|
|
|
|
mock os.getgroups and grp.getgrnam
|
|
|
|
$ cat >> $TESTTMP/mockgrp.py << EOF
|
|
> import os, grp
|
|
> def _getgroups():
|
|
> return map(int, os.environ.get('HGMOCKGRPS', '1000').split())
|
|
> class _grp(object):
|
|
> def __init__(self, gid):
|
|
> self.gr_gid = gid
|
|
> def _getgrnam(name):
|
|
> if name == 'users':
|
|
> gid = 1000
|
|
> elif name == 'devs':
|
|
> gid = 2000
|
|
> else:
|
|
> raise KeyError()
|
|
> return _grp(gid)
|
|
> os.getgroups = _getgroups
|
|
> grp.getgrnam = _getgrnam
|
|
> EOF
|
|
|
|
$ cat >> $HGRCPATH << EOF
|
|
> mockgrp = $TESTTMP/mockgrp.py
|
|
> [grpcheck]
|
|
> groups = users, devs
|
|
> warning = You should be in %s group.
|
|
> overrides.chgserver.idletimeout = 3
|
|
> overrides.ui.foo = bar
|
|
> EOF
|
|
|
|
when the user is not in those groups, warnings are printed
|
|
|
|
$ hg log
|
|
You should be in devs group.
|
|
$ HGMOCKGRPS=100 hg log
|
|
You should be in users group.
|
|
$ HGMOCKGRPS='100 1000' hg log
|
|
You should be in devs group.
|
|
|
|
customized warning message
|
|
|
|
$ hg --config grpcheck.warning=foo log
|
|
foo
|
|
|
|
no warning if HGPLAIN or grpcheck.warning is empty
|
|
|
|
$ hg --config grpcheck.warning= log
|
|
$ HGPLAIN=1 hg log
|
|
|
|
warning does not affect write action (commit)
|
|
|
|
$ touch a
|
|
$ hg commit -A a -m a
|
|
You should be in devs group.
|
|
$ hg log -T '{rev} {node}\n'
|
|
You should be in devs group.
|
|
0 3903775176ed42b1458a6281db4a0ccf4d9f287a
|
|
|
|
config overrides
|
|
|
|
$ HGPLAIN=1 hg config --untrusted chgserver.idletimeout
|
|
3
|
|
$ cd .. # use repo ui
|
|
$ HGPLAIN=1 hg config --untrusted ui.foo
|
|
bar
|