mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 23:07:18 +03:00
34e11242ee
Before this patch, every Python process during a code coverage run was writing coverage data to the same file. I'm not sure if the coverage package even tries to obtain a lock on the file. But what I do know is there was some last write wins leading to loss of code coverage data, at least with -j > 1. This patch changes the code coverage mechanism to be multiple process safe. The mechanism for initializing code coverage via sitecustomize.py has been tweaked so each Python process will produce a separate coverage data file on disk. Unless two processes generate the same random value, there are no race conditions writing to the same file. At the end of the test run, we combine all written files into an aggregate report. On my machine, running the full test suite produces a little over 20,000 coverage files consuming ~350 MB. As you can imagine, it takes several seconds to load and merge these coverage files. But when it is done, you have an accurate picture of the aggregate code coverage for the entire test suite, which is ~60% line coverage.
17 lines
510 B
Python
17 lines
510 B
Python
import os
|
|
|
|
if os.environ.get('COVERAGE_PROCESS_START'):
|
|
try:
|
|
import coverage
|
|
import random
|
|
|
|
# uuid is better, but not available in Python 2.4.
|
|
covpath = os.path.join(os.environ['COVERAGE_DIR'],
|
|
'cov.%s' % random.randrange(0, 1000000000000))
|
|
cov = coverage.coverage(data_file=covpath, auto_data=True)
|
|
cov._warn_no_data = False
|
|
cov._warn_unimported_source = False
|
|
cov.start()
|
|
except ImportError:
|
|
pass
|