sapling/eden
Jun Wu df7fc44718 localrepo: improve edenapi None error reporting
Summary:
Previously the None edenapi error isn't great for understanding what's going on:

  File "edenscm/mercurial/changelog2.py", line 123, in _openhybrid
    inner = bindings.dag.commits.openhybrid(
  TypeError: Expected type that converts to client but received NoneType

Let's make edenapi non-nullable by default, with nicer error messages, and make
places using the nullable edenapi opt-in explicitly.

Example errors:

  % lhg sl --config edenapi.url=
  abort: edenapi is required but disabled by missing edenapi.url config

  % lhg sl --config edenapi.enable=
  abort: edenapi is required but disabled by edenapi.enable being empty

  % lhg sl --config paths.default=/tmp
  abort: edenapi is required but disabled by paths.default being 'file:'

  % lhg sl --config paths.default=ssh://x --config ui.ssh=dummyssh
  abort: edenapi is required but disabled by paths.default being 'ssh:' and dummyssh in use

Reviewed By: kulshrax

Differential Revision: D29462258

fbshipit-source-id: 84fab5a7cce837c52ccb8108d1f4fe44ef2b6d1e
2021-06-29 15:46:00 -07:00
..
fs file access logging in FileInode 2021-06-29 09:45:47 -07:00
hg-server third-party/rust: update Tokio to 1.7.1 2021-06-25 06:17:41 -07:00
integration suppress errors in fbcode/eden - batch 1 2021-06-29 12:29:06 -07:00
locale
mononoke metaconfig: add BlameVersion 2021-06-29 10:32:40 -07:00
scm localrepo: improve edenapi None error reporting 2021-06-29 15:46:00 -07:00
test_support suppress errors in fbcode/eden - batch 1 2021-06-08 11:50:05 -07:00
test-data
.gitignore
Eden.project.toml