mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 14:58:03 +03:00
ee4cd1bb2b
Summary: As we changed how Ctrl+C is handled, there would be more "abandoned transaction"s, just silently cleaned them up. Practically, we should never hit the "abandoned transaction found" case, because the `journal` file only contains how to truncate files to recover. Only legacy revlog uses file truncation and we don't use them in production. There might be a `journal.backupfiles` that tracks what files to rename to restore backup. Most of the key files like `bookmarks` are in metalog therefore no need to use backupfiles to restore. The remaining ones also seem fine to not restore in the old way: - dirstate: we use atomic replace on transaction close so it seems unnecessary to backup - fncache: not used by remotefilelog - phaseroots: not used when narrow-heads is on - commitcloudstate.<name>.<hash>: source of truth moved to metalog by D35232804 (3807e9662b). - commitcloud/backedupheads.remote: used for "backed up" rendering in smartlog, not fatal if not restored. We might clean them up later. For now, let's just silently recover without printing the legacy messages. Note D33482320 (e75c4ca2d8) is incorrect about `journal` being empty = no-op recover, since `journal.backupfiles` could be non-empty and trigger side effects on `recover`. Reviewed By: muirdm Differential Revision: D42912639 fbshipit-source-id: 8a576d2b73b2ffc053e4fc699f323a1f72498feb
29 lines
558 B
Perl
29 lines
558 B
Perl
#chg-compatible
|
|
#debugruntest-compatible
|
|
$ configure modernclient
|
|
$ newclientrepo repo
|
|
$ echo a > a
|
|
$ hg ci -Am0
|
|
adding a
|
|
$ hg push -q -r . --to book --create
|
|
|
|
$ newclientrepo foo test:repo_server book
|
|
$ cd ../repo
|
|
|
|
Journal is cleaned up automatically.
|
|
$ echo something > .hg/store/journal
|
|
|
|
$ echo foo > a
|
|
$ hg ci -Am0
|
|
couldn't read journal entry 'something\n'!
|
|
|
|
$ hg recover
|
|
no interrupted transaction available
|
|
[1]
|
|
|
|
Empty journal is cleaned up automatically.
|
|
$ touch .hg/store/journal
|
|
$ hg ci -Am0
|
|
nothing changed
|
|
[1]
|