mirror of
https://github.com/facebook/sapling.git
synced 2024-10-08 15:57:43 +03:00
a7c49e2ec2
The sparse extension performs a lot of monkeypatching of dirstate to make it sparse aware. Essentially, various operations need to take the active sparse config into account. They do this by obtaining a matcher representing the sparse config and filtering paths through it. The monkeypatching is done by stuffing a reference to a repo on dirstate and calling sparse.matcher() (which takes a repo instance) during each function call. The reason this function takes a repo instance is because resolving the sparse config may require resolving file contents from filelogs, and that requires a repo. (If the current sparse config references "profile" files, the contents of those files from the dirstate's parent revisions is resolved.) I seem to recall people having strong opinions that the dirstate object not have a reference to a repo. So copying what the sparse extension does probably won't fly in core. Plus, the dirstate modifications shouldn't require a full repo: they only need a matcher. So there's no good reason to stuff a reference to the repo in dirstate. This commit exposes a sparse matcher to dirstate via a property that when looked up will call a function that eventually calls sparse.matcher(). The repo instance is bound in a closure, so it isn't exposed to dirstate. This approach is functionally similar to what the sparse extension does today, except it hides the repo instance from dirstate. The approach is not optimal because we have to call a proxy function and sparse.matcher() on every property lookup. There is room to cache the matcher instance in dirstate. After all, the matcher only changes if the dirstate's parents change or if the sparse config changes. It feels like we should be able to detect both events and update the matcher when this occurs. But for now we preserve the existing semantics so we can move the dirstate sparseness bits into core. Once in core, refactoring becomes a bit easier since it will be clearer how all these components interact. The sparse extension has been updated to use the new property. Because all references to the repo on dirstate have been removed, the code for setting it has been removed. |
||
|---|---|---|
| .. | ||
| convert | ||
| fsmonitor | ||
| highlight | ||
| largefiles | ||
| zeroconf | ||
| __init__.py | ||
| acl.py | ||
| automv.py | ||
| blackbox.py | ||
| bugzilla.py | ||
| censor.py | ||
| children.py | ||
| churn.py | ||
| clonebundles.py | ||
| color.py | ||
| eol.py | ||
| extdiff.py | ||
| factotum.py | ||
| fetch.py | ||
| gpg.py | ||
| graphlog.py | ||
| hgk.py | ||
| histedit.py | ||
| journal.py | ||
| keyword.py | ||
| logtoprocess.py | ||
| mq.py | ||
| notify.py | ||
| pager.py | ||
| patchbomb.py | ||
| purge.py | ||
| rebase.py | ||
| record.py | ||
| releasenotes.py | ||
| relink.py | ||
| schemes.py | ||
| share.py | ||
| shelve.py | ||
| show.py | ||
| sparse.py | ||
| strip.py | ||
| transplant.py | ||
| win32mbcs.py | ||
| win32text.py | ||