mirror of
https://github.com/facebook/sapling.git
synced 2024-12-29 16:12:23 +03:00
d89eab8078
Summary: In the cpython bindings, the Rust String can take both PyBytes and PyUnicode strings, which is perfect for Python3 compatibility as string literals are PyBytes in Python2 and PyUnicode in Python3. The return values are kept as Bytes for now as changing this is a much larger change in itself. Other approaches tried: - Using PyUnicode as input/output: an extremely large codemod had to be done, with very little benefits - Using String as output: since we do have some configs that are unicode, on the Python side, the output might either be bytestrings or unicode, leading to weird bugs. Reviewed By: DurhamG Differential Revision: D18650466 fbshipit-source-id: aebdf30590dcae40b7df2787e5ece88e2ec9395c |
||
---|---|---|
.. | ||
benches | ||
src | ||
Cargo.toml | ||
CMakeLists.txt | ||
ConfigParser.cpp | ||
ConfigParser.h |