sapling/lib/manifest
Stefan Filip 6e9cdfe56c manifest: fix finalize to not eagerly fetch directories
Summary:
Finalize is asking the cursor to traverse into directories that haven't changed.
This is bug introduced when updating finalize to support being called on
"Durable" nodes. Until then directories would always be traversed if they were
in the processing path. The path would only be chosen for "Ephemeral"
directories which we knew were different from a parent that is assumed to be
"Durable". I later learned that `finalize` is expected to return the manifests
that are directly fetched from storage. The update meant that we would skip
the directory that is processed if the "Node" (hash) is present and matches a
parent. The problem is that didn't update the point at which the parent cursor
is advanced.

Reviewed By: xavierd

Differential Revision: D17537448

fbshipit-source-id: 9c71a8f8f5a70c600031bc9d32535e59f2f32700
2019-09-24 10:13:38 -07:00
..
src manifest: fix finalize to not eagerly fetch directories 2019-09-24 10:13:38 -07:00
Cargo.toml replace std::sync{Mutex, RwLock, Condvar} with parking_lot 2019-09-13 15:16:57 -07:00