mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
b1a4f2f7be
Summary: Current we treat missing just as any other error, and that makes it hard to have an alarm on blobs that are missing, because any transient error might make this alarm go off. Let's instead differentiate between a blob being missing and failed to fetch a blob because of any other error (i.e. manifold is unavaialble). Turned out this is not too difficult to do because a lot of the types implement Loadable trait, which has Missing variant in its errors. side-note: It looks like we have 3 steps which treat missing blobs as not being an error. These steps are: 1) fastlog_dir_step 2) fastlog_file_step 3) hg_filenode_step I think this is wrong, and I plan to fix it in the next diff Reviewed By: ahornby Differential Revision: D27400280 fbshipit-source-id: e79fff25c41e4d03d77b72b410d6d2f0822c28fd |
||
---|---|---|
.. | ||
schemas | ||
src | ||
Cargo.toml |