facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 07:17:55 +03:00
Code Issues Projects Releases Wiki Activity
b4f3c70c6a
sapling/eden/cli
History
Michael Bolin 9d849ca35c Catch subprocess.CalledProcessError instead of OSError in eden doctor. 
Summary:
Before I fixed an issue with `nuclide-connections` in D7833410, it could throw
an error. Although there was a try/except around the `check_output` call in
`eden doctor`, it caught `OSError` rather than `CalledProcessError`, which
seems like a mistake (or maybe an inadvertent evolution of the code).

While there, I also extended it to catch `ValueError` in case the stdout of the
subprocess is not valid JSON, in which case `json.loads()` will raise a
`ValueError`.

Reviewed By: chadaustin

Differential Revision: D7890571

fbshipit-source-id: 184f6f669e9d62a5fb04db29bcbab450defc226e
2018-05-07 11:24:20 -07:00
..
test Colorize eden doctor output when attached to a tty. 2018-05-07 11:24:20 -07:00
cmd_util.py add type annotations to eden CLI code 2018-03-28 22:22:31 -07:00
config.py remove the eden checkout command 2018-04-25 14:21:47 -07:00
configinterpolator.py Upgrade tests to use Python 3. 2017-12-01 17:21:35 -08:00
debug.py Colorize eden doctor output when attached to a tty. 2018-05-07 11:24:20 -07:00
doctor.py Catch subprocess.CalledProcessError instead of OSError in eden doctor. 2018-05-07 11:24:20 -07:00
main.py improve aux process shutdown handling 2018-05-04 12:02:19 -07:00
mtab.py bring back eden doctor's stale mounts check - filter by st_uid and st_dev instead of path 2018-01-25 15:14:58 -08:00
rage.py refactor CLI subcommand definitions 2018-04-19 17:59:51 -07:00
stats_print.py replace the system memory info in eden stats with process memory 2017-12-18 12:00:58 -08:00
stats.py refactor CLI subcommand definitions 2018-04-19 17:59:51 -07:00
stdout_printer.py Colorize eden doctor output when attached to a tty. 2018-05-07 11:24:20 -07:00
subcmd.py remove ugly default list of subcommands from eden help 2018-04-26 17:11:29 -07:00
util.py thread the clone revision through when loading arcconfig 2018-04-28 17:03:33 -07:00
version.py don't throw in the version check if eden is not installed 2018-01-30 21:50:39 -08:00