mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 00:14:35 +03:00
ef04ccf546
Summary: D17135557 added a bunch of `pyre-fixme` comments to the EdenFS integration tests for cases where Pyre cannot detect that some attributes are initialized by the test case `setUp()` method. It looks like Pyre's handling of `setUp()` is somewhat incorrect: it looks like if a class has a `setUp()` method this currently suppresses all uninitialized attribute errors (even if some attributes really are never initialized). However, Pyre does not detect `setUp()` methods inherited from parent classes, and always warns about uninitialized attributes in this case even they are initialized. Lets change these comments from `pyre-fixme` to `pyre-ignore` since this appears to be an issue with Pyre rather than with this code. T62487924 is open to track adding support for annotating custom constructor methods, which might help here. I've also posted in Pyre Q&A about incorrect handling of `setUp()` in derived classes. Reviewed By: grievejia Differential Revision: D19963118 fbshipit-source-id: 9fd13fc8665367e0780f871a5a0d9a8fe50cc687
103 lines
3.7 KiB
Python
103 lines
3.7 KiB
Python
#!/usr/bin/env python3
|
|
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2.
|
|
|
|
import logging
|
|
import os
|
|
from typing import Dict, List
|
|
|
|
from eden.integration.lib.hgrepo import HgRepository
|
|
from eden.integration.lib.util import gen_tree
|
|
|
|
from .lib.hg_extension_test_base import EdenHgTestCase, hg_test
|
|
|
|
|
|
@hg_test
|
|
# pyre-ignore[13]: T62487924
|
|
class StatusDeadlockTest(EdenHgTestCase):
|
|
"""
|
|
Test running an "hg status" command that needs to import many directories
|
|
and .gitignore files.
|
|
|
|
This attempts to exercise a deadlock issue we had in the past where all of
|
|
the EdenServer thread pool threads would be blocked waiting on operations
|
|
that needed a thread from this pool to complete. Eden wouldn't be able to
|
|
make forward progress from this state.
|
|
"""
|
|
|
|
commit1: str
|
|
commit2: str
|
|
expected_status: Dict[str, str] = {}
|
|
|
|
def edenfs_logging_settings(self) -> Dict[str, str]:
|
|
levels = {"eden": "DBG2"}
|
|
if logging.getLogger().getEffectiveLevel() <= logging.DEBUG:
|
|
levels["eden.fs.store.hg"] = "DBG9"
|
|
return levels
|
|
|
|
def populate_backing_repo(self, repo: HgRepository) -> None:
|
|
logging.debug("== populate_backing_repo")
|
|
|
|
# By default repo.write_file() also calls "hg add" on the path.
|
|
# Unfortunately "hg add" is really slow. Disable calling it one at a
|
|
# time on these files as we write them. We'll make a single "hg add"
|
|
# call at the end with all paths in a single command.
|
|
new_files = []
|
|
|
|
fanouts = [4, 4, 4, 4]
|
|
|
|
def populate_dir(path: str) -> None:
|
|
logging.debug("populate %s", path)
|
|
test_path = os.path.join(path, "test.txt")
|
|
repo.write_file(test_path, f"test\n{path}\n", add=False)
|
|
new_files.append(test_path)
|
|
|
|
gitignore_path = os.path.join(path, ".gitignore")
|
|
gitignore_contents = f"*.log\n/{path}/foo.txt\n"
|
|
repo.write_file(gitignore_path, gitignore_contents, add=False)
|
|
new_files.append(gitignore_path)
|
|
|
|
gen_tree("src", fanouts, populate_dir, populate_dir)
|
|
|
|
self._hg_add_many(repo, new_files)
|
|
|
|
self.commit1 = repo.commit("Initial commit.")
|
|
logging.debug("== created initial commit")
|
|
|
|
new_files = []
|
|
|
|
def create_new_file(path: str) -> None:
|
|
logging.debug("add new file in %s", path)
|
|
new_path = os.path.join(path, "new.txt")
|
|
repo.write_file(new_path, "new\n", add=False)
|
|
new_files.append(new_path)
|
|
self.expected_status[new_path] = "?"
|
|
|
|
gen_tree("src", fanouts, create_new_file)
|
|
self._hg_add_many(repo, new_files)
|
|
|
|
self.commit2 = repo.commit("Initial commit.")
|
|
logging.debug("== created second commit")
|
|
|
|
def _hg_add_many(self, repo: HgRepository, paths: List[str]) -> None:
|
|
# Call "hg add" with at most chunk_size files at a time
|
|
chunk_size = 250
|
|
for n in range(0, len(paths), chunk_size):
|
|
logging.debug("= add %d/%d", n, len(paths))
|
|
repo.add_files(paths[n : n + chunk_size])
|
|
|
|
def test(self) -> None:
|
|
# Reset our working directory parent from commit2 to commit1.
|
|
# This forces us to have an unclean status, but eden won't need
|
|
# to load the source control state yet. It won't load the affected
|
|
# trees until we run "hg status" below.
|
|
self.hg("reset", "--keep", self.commit1)
|
|
|
|
# Now run "hg status".
|
|
# This will cause eden to import all of the trees and .gitignore
|
|
# files as it performs the status operation.
|
|
logging.debug("== checking status")
|
|
self.assert_status(self.expected_status)
|