sapling/tests/test-fb-hgext-checkmessagehook-t.py
Jun Wu 5e5465c313 testutil/dott: match shell's behavior on quote handling
Summary:
This diff makes the code closer to shell behavior.

For example, globs are disabled for both single and double quotes:

  ~ % echo /bin/bash*
  /bin/bash /bin/bashbug
  ~ % echo "/bin/bash*"
  /bin/bash*
  ~ % echo '/bin/bash*'
  /bin/bash*

Environment variables are not expanded for single qutoes:

  ~ % echo $PWD
  /home/quark
  ~ % echo "$PWD"
  /home/quark
  ~ % echo '$PWD'
  $PWD

Tests using single quoted environment varialbes are updated to use double
quotes, mostly by using this vim command:

  %s/\(sh % ".*\)'\([^'$]*\$[^']*\)'/\1\\"\2\\"

The translation script was updated to prefer double quotes to preserve
environment variable expansion behavior.

Reviewed By: xavierd

Differential Revision: D17675351

fbshipit-source-id: d5c8d5f23ea8e29fe093c4e6ae89ddacda97141e
2019-09-30 16:53:25 -07:00

37 lines
1.0 KiB
Python

# Copyright (c) Facebook, Inc. and its affiliates.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
from testutil.dott import feature, sh, testtmp # noqa: F401
sh % "cat" << r"""
[extensions]
checkmessagehook=
""" >> "$HGRCPATH"
# Build up a repo
sh % "hg init repo"
sh % "cd repo"
sh % "touch a"
sh % 'hg commit -A -l "$TESTDIR/ctrlchar-msg.txt"' == r"""
adding a
non-printable characters in commit message
Line 5: 'This has a sneaky ctrl-A: \x01'
Line 6: 'And this has esc: \x1b'
transaction abort!
rollback completed
abort: pretxncommit.checkmessage hook failed
[255]"""
sh % 'hg commit -A -l "$TESTDIR/perfectlyok-msg.txt"' == "adding a"
sh % "hg log -r ." == r"""
changeset: 0:d9cf9881be7b
tag: tip
user: test
date: Thu Jan 01 00:00:00 1970 +0000
summary: This commit message is perfectly OK, and has no sneaky control characters."""