mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 09:17:30 +03:00
d678fe1702
Summary: `ascii` was used as the default / fallback, which is not a user-friendly choice. Nowadays utf-8 dominates: - Rust stdlib is utf-8. - Ruby since 1.9 is utf-8 by default. - Python 3 is unicode by default. - Windows 10 adds utf-8 code page. Given the fact that: - Our CI sets HGENCODING to utf-8 - Nuclide passes `--encoding=utf-8` to every command. - Some people have messed up with `LC_*` and complained about hg crashes. - utf-8 is a super set of ascii, nobody complains that they want `ascii` encoding and the `utf-8` encoding messed their setup up. Let's just use `utf-8` as the default encoding. More aggressively, if someone sets `ascii` as the encoding, it's almost always a mistake. Auto-correct that to `utf-8` too. This should also make future integration with Rust easier (where it's enforced utf-8 and does not have an option to change the encoding). In the future we might just drop the flexibility of choosing customized encoding, so this diff autofixes `ascii` to `utf-8`, instead of allowing `ascii` to be set. We cannot enforce `utf-8` yet, because of Windows. Here is our encoding strategy vs the upstream's: | item | upstream | | ours | ours | | | current | ideal | current | ideal | | CLI argv | bytes | bytes | utf-8 [1] | utf-8 | | path | bytes | auto [3] | migrating [2] | utf-8 | | commit message | utf-8 | utf-8 | utf-8 | utf-8 | | bookmark name | utf-8 | utf-8 | utf-8 | utf-8 | | file content | bytes | bytes | bytes | bytes | [1]: Argv was accidentally enforced utf-8 for command-line arguments by a Rust wrapper. But it simplified a lot of things and is kind of ok: everything that can be passed as CLI arguments are utf-8: -M commit message, -b bookmark, paths, etc. There is no "file content" passed via CLI arguments. [2]: Path is controversial, because it's possible for systems to have non-utf8 paths. The upstream behavior is incorrect if a repo gets shared among different encoding systems (ex. both Linux and Windows). We have to know the encoding of paths to be able to convert them suitable for the local system. One way is to enforce UTF-8 for paths. The other is to keep encoding information stored with individual paths (like Ruby strings). The UTF-8 approach is much simpler with the tradeoff that non-utf-8 paths become unsupported, which seems to be a reasonable trade-off. [3]: See https://www.mercurial-scm.org/wiki/WindowsUTF8Plan. Reviewed By: singhsrb Differential Revision: D17098991 fbshipit-source-id: c0ff1e586a887233bd43cdb854fb3538aa9b70c2
123 lines
4.8 KiB
Perl
123 lines
4.8 KiB
Perl
hg debuginstall
|
|
$ hg debuginstall
|
|
checking encoding (utf-8)...
|
|
checking Python executable (*) (glob)
|
|
checking Python version (2.*) (glob)
|
|
checking Python lib (*lib*)... (glob)
|
|
checking Python security support (*) (glob)
|
|
TLS 1.2 not supported by Python install; network connections lack modern security (?)
|
|
SNI not supported by Python install; may have connectivity issues with some servers (?)
|
|
checking Mercurial version (*) (glob)
|
|
checking Mercurial custom build (*) (glob)
|
|
checking module policy (*) (glob)
|
|
checking installed modules (*mercurial)... (glob)
|
|
checking registered compression engines (*zlib*) (glob)
|
|
checking available compression engines (*zlib*) (glob)
|
|
checking available compression engines for wire protocol (*zlib*) (glob)
|
|
checking "re2" regexp engine \((available|missing)\) (re)
|
|
checking templates (*mercurial?templates)... (glob)
|
|
checking default template (default)
|
|
checking commit editor... (* -c "import sys; sys.exit(0)") (glob)
|
|
checking username (test)
|
|
no problems detected
|
|
|
|
hg debuginstall JSON
|
|
$ hg debuginstall -Tjson | sed 's|\\\\|\\|g'
|
|
[
|
|
{
|
|
"compengines": ["bz2", "bz2truncated", "none", "zlib"*], (glob)
|
|
"compenginesavail": ["bz2", "bz2truncated", "none", "zlib"*], (glob)
|
|
"compenginesserver": [*"zlib"*], (glob)
|
|
"defaulttemplate": "default",
|
|
"defaulttemplateerror": null,
|
|
"defaulttemplatenotfound": "default",
|
|
"editor": "* -c \"import sys; sys.exit(0)\"", (glob)
|
|
"editornotfound": false,
|
|
"encoding": "utf-8",
|
|
"encodingerror": null,
|
|
"extensionserror": null, (no-pure !)
|
|
"hgmodulepolicy": "*", (glob)
|
|
"hgmodules": "*mercurial", (glob)
|
|
"hgver": "*", (glob)
|
|
"hgverextra": "*", (glob)
|
|
"problems": 0,
|
|
"pythonexe": "*", (glob)
|
|
"pythonlib": "*", (glob)
|
|
"pythonsecurity": [*], (glob)
|
|
"pythonver": "*.*.*", (glob)
|
|
"re2": (true|false), (re)
|
|
"templatedirs": "*mercurial?templates", (glob)
|
|
"username": "test",
|
|
"usernameerror": null,
|
|
"vinotfound": false
|
|
}
|
|
]
|
|
|
|
hg debuginstall with no username
|
|
$ HGUSER= hg debuginstall
|
|
checking encoding (utf-8)...
|
|
checking Python executable (*) (glob)
|
|
checking Python version (2.*) (glob)
|
|
checking Python lib (*lib*)... (glob)
|
|
checking Python security support (*) (glob)
|
|
TLS 1.2 not supported by Python install; network connections lack modern security (?)
|
|
SNI not supported by Python install; may have connectivity issues with some servers (?)
|
|
checking Mercurial version (*) (glob)
|
|
checking Mercurial custom build (*) (glob)
|
|
checking module policy (*) (glob)
|
|
checking installed modules (*mercurial)... (glob)
|
|
checking registered compression engines (*zlib*) (glob)
|
|
checking available compression engines (*zlib*) (glob)
|
|
checking available compression engines for wire protocol (*zlib*) (glob)
|
|
checking "re2" regexp engine \((available|missing)\) (re)
|
|
checking templates (*mercurial?templates)... (glob)
|
|
checking default template (default)
|
|
checking commit editor... (* -c "import sys; sys.exit(0)") (glob)
|
|
checking username...
|
|
no username supplied
|
|
(specify a username in your configuration file)
|
|
1 problems detected, please check your install!
|
|
[1]
|
|
|
|
hg debuginstall with invalid encoding
|
|
$ HGENCODING=invalidenc hg debuginstall | grep encoding
|
|
checking encoding (invalidenc)...
|
|
unknown encoding: invalidenc
|
|
|
|
exception message in JSON
|
|
|
|
$ HGENCODING=invalidenc HGUSER= hg debuginstall -Tjson | grep error
|
|
"defaulttemplateerror": null,
|
|
"encodingerror": "unknown encoding: invalidenc",
|
|
"extensionserror": null, (no-pure !)
|
|
"usernameerror": "no username supplied",
|
|
|
|
path variables are expanded (~ is the same as $TESTTMP)
|
|
$ mkdir tools
|
|
$ touch tools/testeditor.exe
|
|
#if execbit
|
|
$ chmod 755 tools/testeditor.exe
|
|
#endif
|
|
$ hg debuginstall --config ui.editor=~/tools/testeditor.exe
|
|
checking encoding (utf-8)...
|
|
checking Python executable (*) (glob)
|
|
checking Python version (*) (glob)
|
|
checking Python lib (*lib*)... (glob)
|
|
checking Python security support (*) (glob)
|
|
TLS 1.2 not supported by Python install; network connections lack modern security (?)
|
|
SNI not supported by Python install; may have connectivity issues with some servers (?)
|
|
checking Mercurial version (*) (glob)
|
|
checking Mercurial custom build (*) (glob)
|
|
checking module policy (*) (glob)
|
|
checking installed modules (*mercurial)... (glob)
|
|
checking registered compression engines (*zlib*) (glob)
|
|
checking available compression engines (*zlib*) (glob)
|
|
checking available compression engines for wire protocol (*zlib*) (glob)
|
|
checking "re2" regexp engine \((available|missing)\) (re)
|
|
checking templates (*mercurial?templates)... (glob)
|
|
checking default template (default)
|
|
checking commit editor... (* -c "import sys; sys.exit(0)") (glob)
|
|
checking username (test)
|
|
no problems detected
|
|
|