mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
d18ce1082e
Summary: This refactors the `edenfsctl start` command so that we more clearly split the functionality into two pieces: * Starting EdenFS as a service * Running EdenFS in the foreground In most normal situations in production the `start`, `restart`, and `stop` commands are used to manage running EdenFS as a service. In the future I believe our service management logic will start to diverge a bit more on Linux vs Mac vs Windows, and this should help isolate the service-management code a bit more cleanly. The foreground behavior is mainly only used by developers during testing and during the integration tests. Several options like `--gdb` and `--strace` are only allowed in foreground mode, and this refactoring makes that clearer. In the future we may also want to further restrict this, to allow only specifying additional custom arguments and a custom binary path when running in foreground mode. However, for now I have not updated that as I believe some of our integration tests may be exercising this behavior today. This change also cleans up some of the platform-specific code, and lets them share more of the logic to construct arguments for edenfs. With this change `edenfsctl start --foreground` now works on Windows. Reviewed By: pkaush Differential Revision: D20833244 fbshipit-source-id: 0f09d59702d8b64ca8f4fedccbc30da1c858afb4 |
||
|---|---|---|
| .. | ||
| mount | ||
| service | ||
| store | ||
| testharness | ||
| utils | ||
| CMakeLists.txt | ||
| Edenwin.h | ||