mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
b909f2bc9c
Summary: Previously we had a timeout per session i.e. multiple wireproto command will share the same timeout. It had a few disadvantages: 1) The main disadvantage was that if connection had timed out we didn't log stats such as number of files, response size etc and we didn't log parameters to scribe. The latter is even a bigger problem, because we usually want to replay requests that were slow and timed out and not the requests that finished quickly. 2) The less important disadvantage is that we have clients that do small request from the server and then keep the connection open for a long time. Eventually we kill the connection and log it as an error. With this change the connection will be open until client closes it. That might potentially be a problem, and if that's the case then we can reintroduce perconnection timeout. Initially I was planning to use tokio::util::timer to implement all the timeouts, but it has different behaviour for stream - it only allows to set per-item timeout, while we want timeout for the whole stream. (https://docs.rs/tokio/0.1/tokio/timer/struct.Timeout.html#futures-and-streams) To overcome it I implemented simple combinator StreamWithTimeout which does exactly what I want. Reviewed By: HarveyHunt Differential Revision: D13731966 fbshipit-source-id: 211240267c7568cedd18af08155d94bf9246ecc3 |
||
|---|---|---|
| .. | ||
| context/src | ||
| repo_listener/src | ||
| src | ||
| Cargo.toml | ||