mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 23:07:18 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
88 lines
2.1 KiB
Python
88 lines
2.1 KiB
Python
# Test that certain objects conform to well-defined interfaces.
|
|
|
|
from __future__ import absolute_import, print_function
|
|
|
|
from mercurial import (
|
|
bundlerepo,
|
|
httppeer,
|
|
localrepo,
|
|
sshpeer,
|
|
statichttprepo,
|
|
ui as uimod,
|
|
unionrepo,
|
|
)
|
|
|
|
|
|
def checkobject(o):
|
|
"""Verify a constructed object conforms to interface rules.
|
|
|
|
An object must have __abstractmethods__ defined.
|
|
|
|
All "public" attributes of the object (attributes not prefixed with
|
|
an underscore) must be in __abstractmethods__ or appear on a base class
|
|
with __abstractmethods__.
|
|
"""
|
|
name = o.__class__.__name__
|
|
|
|
allowed = set()
|
|
for cls in o.__class__.__mro__:
|
|
if not getattr(cls, "__abstractmethods__", set()):
|
|
continue
|
|
|
|
allowed |= cls.__abstractmethods__
|
|
allowed |= {a for a in dir(cls) if not a.startswith("_")}
|
|
|
|
if not allowed:
|
|
print("%s does not have abstract methods" % name)
|
|
return
|
|
|
|
public = {a for a in dir(o) if not a.startswith("_")}
|
|
|
|
for attr in sorted(public - allowed):
|
|
print("public attributes not in abstract interface: %s.%s" % (name, attr))
|
|
|
|
|
|
# Facilitates testing localpeer.
|
|
class dummyrepo(object):
|
|
|
|
def __init__(self):
|
|
self.ui = uimod.ui()
|
|
|
|
def filtered(self, name):
|
|
pass
|
|
|
|
def _restrictcapabilities(self, caps):
|
|
pass
|
|
|
|
|
|
# Facilitates testing sshpeer without requiring an SSH server.
|
|
class testingsshpeer(sshpeer.sshpeer):
|
|
|
|
def _validaterepo(self, *args, **kwargs):
|
|
pass
|
|
|
|
|
|
class badpeer(httppeer.httppeer):
|
|
|
|
def __init__(self):
|
|
super(badpeer, self).__init__(uimod.ui(), "http://localhost")
|
|
self.badattribute = True
|
|
|
|
def badmethod(self):
|
|
pass
|
|
|
|
|
|
def main():
|
|
ui = uimod.ui()
|
|
|
|
checkobject(badpeer())
|
|
checkobject(httppeer.httppeer(ui, "http://localhost"))
|
|
checkobject(localrepo.localpeer(dummyrepo()))
|
|
checkobject(testingsshpeer(ui, "ssh://localhost/foo"))
|
|
checkobject(bundlerepo.bundlepeer(dummyrepo()))
|
|
checkobject(statichttprepo.statichttppeer(dummyrepo()))
|
|
checkobject(unionrepo.unionpeer(dummyrepo()))
|
|
|
|
|
|
main()
|