bd50a8cde1
Summary: When the underlying stream in a `BytesStream` hits EOF, and the `BytesStream` is asked for more data, it'll busy loop until more data becomes available. This happens because when the `BytesStream` hits EOF on the underlying stream, it'll record that the stream is done, and won't ever poll the underlying stream again in `poll_buffer`. However, in `poll_buffer_until`, we essentially busy loop through calls to `poll_buffer` When that happens, the process goes into an infinite loop of: - Checking that it doesn't have enough bytes. - Observing that the stream is done. - Calling `poll_buffer` and not making any progress. Instead, the right behavior would be to return a successful read of length zero in `read()` to indicate EOF to the caller. This is what this patch does. It's worth noting that even if the underlying stream returned more data after it reported it was exhausted (callers should avoid polling them again ... or use `fuse()`), the `BytesStream` won't ever poll for that data, since it skips the poll because `stream_done` is set. Reviewed By: farnz Differential Revision: D16130672 fbshipit-source-id: a61c39feb1aa1ac74bbef909e47d698051477533 |
||
---|---|---|
apiserver | ||
async-compression | ||
asyncmemo | ||
benchmark | ||
blobimport_lib/src | ||
blobrepo | ||
blobrepo_utils | ||
blobstore | ||
blobstore_sync_queue | ||
bonsai_hg_mapping | ||
bonsai_utils | ||
bookmarks | ||
bundle2_resolver | ||
bytes-ext | ||
cache_warmup/src | ||
changesets | ||
cmdlib/src | ||
cmds | ||
common | ||
failure_ext | ||
filenodes | ||
futures-ext | ||
hgcli | ||
hgproto | ||
hook_tailer | ||
hooks | ||
mercurial | ||
mercurial_bundles | ||
mercurial_types | ||
metaconfig | ||
mononoke_api/src | ||
mononoke_types | ||
netstring | ||
phases | ||
py_tar_utils | ||
reachabilityindex | ||
ready_state/src | ||
repo_client | ||
revset | ||
server | ||
sshrelay | ||
tests | ||
.gitignore | ||
.rlsconfig | ||
.travis.yml | ||
Cargo.toml | ||
CONTRIBUTING.md | ||
LICENSE | ||
packman.yml | ||
README.md | ||
rustfmt.toml |
Mononoke
Mononoke is a next-generation server for the Mercurial source control system, meant to scale up to accepting thousands of commits every hour across millions of files. It is primarily written in the Rust programming language.
Caveat Emptor
Mononoke is still in early stages of development. We are making it available now because we plan to start making references to it from our other open source projects such as Eden.
The version that we provide on GitHub does not build yet.
This is because the code is exported verbatim from an internal repository at Facebook, and not all of the scaffolding from our internal repository can be easily extracted. The key areas where we need to shore things up are:
- Full support for a standard
cargo build
. - Open source replacements for Facebook-internal services (blob store, logging etc).
The current goal is to get Mononoke working on Linux. Other Unix-like OSes may be supported in the future