facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 07:17:55 +03:00
Code Issues Projects Releases Wiki Activity
becc32004a
sapling/lib/cdatapack
History
Zeyi Fan 9277617d1e fix double free in cdatapack 
Summary:
Mercurial recently started to generate empty pack files (`0x01`). This will cause this check to fail:

diffusion/FBS/browse/master/fbcode/scm/hg/lib/cdatapack/cdatapack.c;2c4197d003ed906dd8eaf70fbb04aa53440ce681$314-319

This will subsequently result as a double-free error between these two:

**In `error_cleanup`**

diffusion/FBS/browse/master/fbcode/scm/hg/lib/cdatapack/cdatapack.c;2c4197d003ed906dd8eaf70fbb04aa53440ce681$387-389

**In `close_datapack`**

diffusion/FBS/browse/master/fbcode/scm/hg/lib/cdatapack/cdatapack.c;2c4197d003ed906dd8eaf70fbb04aa53440ce681$401

This diff will fix this bug.

Differential Revision: D14759374

fbshipit-source-id: 06f192513a935740c2142b5a2baac87a28903496
2019-04-03 21:13:13 -07:00
..
cdatapack_dump.c hg: disable check-code tests for C code 2018-06-05 19:21:43 -07:00
cdatapack_get.c hg: disable check-code tests for C code 2018-06-05 19:21:43 -07:00
cdatapack.c fix double free in cdatapack 2019-04-03 21:13:13 -07:00
cdatapack.h hg: disable check-code tests for C code 2018-06-05 19:21:43 -07:00
Makefile update cdatapack utilities to check open success 2018-05-24 11:30:48 -07:00