mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
7a95293acb
The way hgsubversion handles URLs that may or may not be quoted is somewhat fragile. As part of fixing issue 132 in 06d89c2063a2, the path component of URLs was always quoted. The URL has been attempted encoded since the initial check-in. The fix from 06d89c2063a2 was incomplete; reverting it allows us to clone a URL with a '~' in it.[1] Encoding the URL as UTF-8 seldom works as expected, as the default string encoding is ASCII, causing Python to be unable to decode any URL containing an 8-bit character. The core problem here is that we don't know whether the URL specified by the user is quoted or not. Rather than trying to deal with this ourselves, we pass the problem on to Subversion. Then, we obtain the URL from the RA instance, where it is always quoted. (It's worth noting that the editor interface, on the other hand, always deals with unquoted paths...) Thus, the following invariants should apply to SubversionRepo attributes: - svn_url and root will always be quoted. - subdir will always be unquoted. Tests are added that verify that it won't affect the conversion whether a URL is specified in quoted or unquoted form. Furthermore, a test fixture for this is added *twice*, so that we can thoroughly test both quoted and unquoted URLs. I'm not adding a test dedicated to tildes in URLs; it doesn't seem necessary. [1] Such as <https://svn.kenai.com/svn/winsw~subversion>.
113 lines
1.5 KiB
Plaintext
113 lines
1.5 KiB
Plaintext
SVN-fs-dump-format-version: 2
|
|
|
|
UUID: a7b92ce5-70a8-4e75-99da-c3ca360ae490
|
|
|
|
Revision-number: 0
|
|
Prop-content-length: 56
|
|
Content-length: 56
|
|
|
|
K 8
|
|
svn:date
|
|
V 27
|
|
2010-08-16T13:08:38.494252Z
|
|
PROPS-END
|
|
|
|
Revision-number: 1
|
|
Prop-content-length: 121
|
|
Content-length: 121
|
|
|
|
K 7
|
|
svn:log
|
|
V 20
|
|
Create project bøb.
|
|
K 10
|
|
svn:author
|
|
V 6
|
|
danchr
|
|
K 8
|
|
svn:date
|
|
V 27
|
|
2010-08-16T13:10:12.395716Z
|
|
PROPS-END
|
|
|
|
Node-path: bøb
|
|
Node-kind: dir
|
|
Node-action: add
|
|
Prop-content-length: 10
|
|
Content-length: 10
|
|
|
|
PROPS-END
|
|
|
|
|
|
Node-path: bøb/branches
|
|
Node-kind: dir
|
|
Node-action: add
|
|
Prop-content-length: 10
|
|
Content-length: 10
|
|
|
|
PROPS-END
|
|
|
|
|
|
Node-path: bøb/tags
|
|
Node-kind: dir
|
|
Node-action: add
|
|
Prop-content-length: 10
|
|
Content-length: 10
|
|
|
|
PROPS-END
|
|
|
|
|
|
Node-path: bøb/trunk
|
|
Node-kind: dir
|
|
Node-action: add
|
|
Prop-content-length: 10
|
|
Content-length: 10
|
|
|
|
PROPS-END
|
|
|
|
|
|
Node-path: bøb/trunk/A
|
|
Node-kind: file
|
|
Node-action: add
|
|
Prop-content-length: 10
|
|
Text-content-length: 1
|
|
Text-content-md5: 68b329da9893e34099c7d8ad5cb9c940
|
|
Text-content-sha1: adc83b19e793491b1c6ea0fd8b46cd9f32e592fc
|
|
Content-length: 11
|
|
|
|
PROPS-END
|
|
|
|
|
|
|
|
Revision-number: 2
|
|
Prop-content-length: 112
|
|
Content-length: 112
|
|
|
|
K 7
|
|
svn:log
|
|
V 11
|
|
Add a file.
|
|
K 10
|
|
svn:author
|
|
V 6
|
|
danchr
|
|
K 8
|
|
svn:date
|
|
V 27
|
|
2010-08-16T14:04:00.624391Z
|
|
PROPS-END
|
|
|
|
Node-path: bøb/trunk/B
|
|
Node-kind: file
|
|
Node-action: add
|
|
Prop-content-length: 10
|
|
Text-content-length: 1
|
|
Text-content-md5: 68b329da9893e34099c7d8ad5cb9c940
|
|
Text-content-sha1: adc83b19e793491b1c6ea0fd8b46cd9f32e592fc
|
|
Content-length: 11
|
|
|
|
PROPS-END
|
|
|
|
|
|
|