mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
c6fd393842
Summary: Removed all references to RepoGenCache from publically callable functions in the revset package. This involved: - Modifying blobrepo so that its get_generation_number method returned a Generation wrapper instead of a raw usize, to allow it to be used in a cleaner manner in the revset code. - Simultaneously changing the constructors of all the structures in revset. This seems like a big change, but many of them call each other, passing a RepoGenCache object down the line, so eliminating them all at once made for the cleanest update. - Modifying helper functions in the revset structures which would create streams of nodes by taking ownership of a RepoGenCache object within a closure. Instead they now take ownership of a clone of the repo. This strategy was already done earlier in the same helper functions, so I am assuming the cost of cloning a repo into a closure is small. - Modifying the only external usage of revset within the mononoke server code. This is part of a several step process to completely remove RepoGenCache from the code base. The next steps should be: - Remove all references to RepoGenCache in the testing macros for revset. - Delete RepoGenCache and clean up any dangling references to it. Reviewed By: StanislavGlebik Differential Revision: D8743560 fbshipit-source-id: 125f851075d836d40224d339e1daee912a39f7e4 |
||
---|---|---|
.. | ||
src | ||
test | ||
Cargo.toml |