facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 14:28:17 +03:00
Code Issues Projects Releases Wiki Activity
c7c032c6fb
sapling/eden/fs/monitor
History
Xavier Deguillard b7d87d807a utils: deny building an AbsolutePath from a literal 
Summary:
We've had a couple of failures after landing D40818724 (f199e93924) due to some places still
building AbsolutePath from a literal. On Windows, this is almost always a bug
due to paths usually not being UNC.

To avoid this issue, we can simply forbid an AbsolutePath from being built in
the first place from a path, instead forcing the use of canonicalPath. This was
suggeted by mshroyer in the orignal diff.

Reviewed By: chadaustin

Differential Revision: D41229194

fbshipit-source-id: 3451bdcba276c87f98326b025e05f6a4eddbd1b7
2022-11-22 16:20:30 -08:00
..
test utils: deny building an AbsolutePath from a literal 2022-11-22 16:20:30 -08:00
EdenInstance.cpp utils: deny building an AbsolutePath from a literal 2022-11-22 16:20:30 -08:00
EdenInstance.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
EdenMonitor.cpp standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
EdenMonitor.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
LogFile.cpp standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
LogFile.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
LogRotation.cpp migrate AbsolutePathPiece, RelativePathPiece, and PathComponentPiece to std::string_view 2022-10-04 21:42:44 -07:00
LogRotation.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
main.cpp migrate to throw_ and throwf 2022-07-08 13:30:53 -07:00
README.md add a new process to monitor EdenFS 2020-01-31 13:22:26 -08:00

README.md

This directory contains a wrapper process that monitors the EdenFS daemon. This wrapper process serves a few purposes:

Simplifies management of EdenFS across graceful restarts

This monitoring process provides a single parent process that can be monitored by systemd and other system management daemons, even across EdenFS graceful restarts. When a graceful restart is desired this wrapper daemon can spawn the new EdenFS instance, so that the new EdenFS instance is still part of the original service process hierarchy.

Note that using a wrapper for this purpose is not strictly required with systemd (it is possible to inform systemd that the main process ID has changed and it should monitor a new process moving forward). However, this wrapper provides us a bit more flexibility and control around the restart mechanism, and also makes it easier to monitor EdenFS with other service management frameworks on other platforms.

Log file management and rotation

This process reads all messages printed by EdenFS to stdout and stderr, and writes them to a log file, performing log rotation when appropriate.

Implementing log rotation properly is tricky otherwise, as there are many different sources that can end up writing data to EdenFS's stdout/stderr descriptors, including separate processes like the privhelper process and spawned Python subprocesses.

Intelligent Restarting of EdenFS when it is Idle

This wrapper process supports requests to trigger a restart at some point in the future when EdenFS appears to be idle.

While graceful restart should minimize user-visible disruption, it can still introduce a delay for I/O operations while the restart is in progress. Therefore it is still desirable to try and perform the restart while users are not actively accessing the file system, if possible.

This functionality is provided by the wrapper primarily because the wrapper provides a convenient location to centralize this management in case multiple restart attempts are requested before EdenFS becomes idle.