facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 16:57:49 +03:00
Code Issues Projects Releases Wiki Activity
ca40c6f0f4
sapling/eden/integration
History
Adam Simpkins ef04ccf546 replace a bunch of pyre-fixme comments with pyre-ignoree 
Summary:
D17135557 added a bunch of `pyre-fixme` comments to the EdenFS integration
tests for cases where Pyre cannot detect that some attributes are initialized
by the test case `setUp()` method.

It looks like Pyre's handling of `setUp()` is somewhat incorrect: it looks
like if a class has a `setUp()` method this currently suppresses all
uninitialized attribute errors (even if some attributes really are never
initialized).  However, Pyre does not detect `setUp()` methods inherited from
parent classes, and always warns about uninitialized attributes in this case
even they are initialized.

Lets change these comments from `pyre-fixme` to `pyre-ignore` since this
appears to be an issue with Pyre rather than with this code.  T62487924 is
open to track adding support for annotating custom constructor methods, which
might help here.  I've also posted in Pyre Q&A about incorrect handling of
`setUp()` in derived classes.

Reviewed By: grievejia

Differential Revision: D19963118

fbshipit-source-id: 9fd13fc8665367e0780f871a5a0d9a8fe50cc687
2020-02-24 18:55:19 -08:00
..
fsck Upgrade Pyre version for eden to 2927613de6d20ee2d66e98124f3834812475e122 2020-02-19 15:05:25 -08:00
helpers log to scuba upon automatic gc 2019-12-10 16:16:35 -08:00
hg replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
lib replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
snapshot Update pyre version for eden 2019-12-20 16:14:21 -08:00
basic_test.py replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
chown_test.py replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
clone_test.py Update pyre version for eden 2020-01-24 12:32:43 -08:00
CMakeLists.txt support running the hg status integration tests in CMake builds 2019-10-04 08:56:38 -07:00
config_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
corrupt_overlay_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
debug_getpath_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
doteden_test.py Update pyre version for eden 2020-02-23 15:25:23 -08:00
edenclient_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
fsck_test.py replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
glob_test.py add EdenErrorType to EdenError 2019-10-29 09:23:03 -07:00
health_test.py Update pyre version for eden 2020-01-24 12:32:43 -08:00
help_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
info_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
linux_cgroup_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
materialized_query_test.py add EdenErrorType to EdenError 2019-10-29 09:23:03 -07:00
mmap_test.py replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
mount_test.py replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
oexcl_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
patch_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
persistence_test.py eden/integration/persistence_test.py 2020-02-24 15:42:45 -08:00
rage_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
rc_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
redirect_test.py eden: remove legacy bind mount concept from redirections 2019-12-04 10:47:14 -08:00
remount_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
rename_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
repo_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
restart_test.py Update pyre version for eden 2019-10-16 16:56:29 -07:00
rocksdb_store_test.py make hgcache direct read as default 2020-02-20 16:58:10 -08:00
sed_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
service_log_test.py Update pyre version for eden 2019-10-16 16:56:29 -07:00
setattr_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
stale_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
start_test.py Update pyre version for eden 2020-01-24 12:32:43 -08:00
stats_test.py stop storing sizes in their own local store column 2019-12-20 16:14:23 -08:00
stop_test.py Update pyre version for eden 2020-01-24 12:32:43 -08:00
systemd_fixture_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
systemd_test.py fork in cli daemon_exec 2020-02-19 08:08:08 -08:00
takeover_test.py replace a bunch of pyre-fixme comments with pyre-ignoree 2020-02-24 18:55:19 -08:00
thrift_test.py Update pyre version for eden 2020-02-23 15:25:23 -08:00
unixsocket_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
unlink_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
userinfo_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00
xattr_test.py Tidy up license headers 2019-10-11 05:28:23 -07:00