mirror of
https://github.com/facebook/sapling.git
synced 2024-10-04 22:07:44 +03:00
ceccbc1682
Summary: X-link: https://github.com/facebookincubator/velox/pull/6924 fix getdeps actions generation for rust toolchain Generated actions files created from getdeps.py were missing rust toolchain which meant annoying manual edits This change also makes the github actions generation honor the --no-tests argument, which is useful when regenerating the edenfs actions Pull Request resolved: https://github.com/facebook/sapling/pull/682 Test Plan: To test we add the missing undeclared rust-shed dependency to the eden manifest and regenerate. Generate updated actions yaml with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden ``` Before, was missing the rust toolchain in the auto regenerated eden actions file. After, toolchain is present Before, was missing the --no-tests in the "Build eden" step of the auto-regenerated eden actions file. After, has it Eden stil needs some other fixes to build, which follow in this stqck --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/682). * https://github.com/facebook/sapling/issues/693 * https://github.com/facebook/sapling/issues/696 * https://github.com/facebook/sapling/issues/692 * https://github.com/facebook/sapling/issues/691 * __->__ https://github.com/facebook/sapling/issues/682 * https://github.com/facebook/sapling/issues/689 * https://github.com/facebook/sapling/issues/697 * https://github.com/facebook/sapling/issues/706 * https://github.com/facebook/sapling/issues/730 Reviewed By: sggutier Differential Revision: D49875258 Pulled By: genevievehelsel fbshipit-source-id: 173f86083ba92bab4063813d3e392df428b9ffe4 |
||
|---|---|---|
| .. | ||
| workflows | ||