mirror of
https://github.com/facebook/sapling.git
synced 2024-10-12 01:39:21 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
58 lines
1.3 KiB
Python
58 lines
1.3 KiB
Python
from __future__ import absolute_import, print_function
|
|
|
|
import os
|
|
|
|
from mercurial import commands, extensions, ui as uimod
|
|
|
|
|
|
ignore = {
|
|
b"highlight",
|
|
b"win32text",
|
|
b"factotum",
|
|
b"remotenames",
|
|
b"lz4revlog",
|
|
b"hgsql",
|
|
b"shelve",
|
|
b"fbconduit",
|
|
b"",
|
|
}
|
|
|
|
if os.name != "nt":
|
|
ignore.add(b"win32mbcs")
|
|
|
|
disabled = [ext for ext in extensions.disabled().keys() if ext not in ignore]
|
|
|
|
hgrc = open(os.environ["HGRCPATH"], "wb")
|
|
hgrc.write(b"[extensions]\n")
|
|
|
|
for ext in disabled:
|
|
hgrc.write(ext + b"=\n")
|
|
|
|
hgrc.close()
|
|
|
|
u = uimod.ui.load()
|
|
|
|
# Some extensions may print useful warning messages when they are loaded without
|
|
# the necessary config options. Let's capture that output since it does not
|
|
# matter for this test.
|
|
u.pushbuffer(error=True)
|
|
extensions.loadall(u)
|
|
u.popbuffer()
|
|
|
|
globalshort = set()
|
|
globallong = set()
|
|
for option in commands.globalopts:
|
|
option[0] and globalshort.add(option[0])
|
|
option[1] and globallong.add(option[1])
|
|
|
|
for cmd, entry in commands.table.items():
|
|
seenshort = globalshort.copy()
|
|
seenlong = globallong.copy()
|
|
for option in entry[1]:
|
|
if (option[0] and option[0] in seenshort) or (
|
|
option[1] and option[1] in seenlong
|
|
):
|
|
print("command '" + cmd + "' has duplicate option " + str(option))
|
|
seenshort.add(option[0])
|
|
seenlong.add(option[1])
|