mirror of
https://github.com/facebook/sapling.git
synced 2024-10-06 06:47:41 +03:00
418ccf5ffd
Summary:
After we added more responsive design in D45671035, some styling seems to have broken and gone unnoticed.
- diff badges are now more more likely to be flex-shrunk by being in a slightly too narrow display that's not narrow enough to fully wrap. We should prevent this text wrap so diff statuses ("landing" etc) never wrap their text
- The uncommit button was top-aligned, but I think center align makes more sense, especially when you see it next to other elements that should be centered (diff badge row)
- In fixing the uncommit button alignment, it messed up commit avatars. However, this is a good opportunity to fix the commit avatar alignment. I noticed in the past they were sometimes askew anyway.
- We instead align avatars to be centered as well (top & bottom : auto)
- This then causes a new bug, where the commit graph line border may poke out above the commit avatar.
- We can cover this up by re-adding the background perfectly aligned with the border, with the right height for the commit, but only do this for the topmost commit of a stack
- Lastly, if its the head commit, then we shouldn't cover up with the background color, but rather the blue color used for "You are here" to blend in properly.
All these things taken together seem to give a good look.
Reviewed By: muirdm
Differential Revision: D45785794
fbshipit-source-id: 2ddb3c552a6d183ea5bc20ae0ba3b8aa32ec9845
|
||
|---|---|---|
| .. | ||
| .tours | ||
| .vscode | ||
| eslint-rules | ||
| isl | ||
| isl-server | ||
| isl-standalone | ||
| reviewstack | ||
| reviewstack.dev | ||
| shared | ||
| textmate | ||
| vscode | ||
| .eslintrc.js | ||
| .gitignore | ||
| .prettierignore | ||
| .prettierrc | ||
| LICENSE | ||
| package.json | ||
| removeInternalFiles.sh | ||
| verify-addons-folder.py | ||
| yarn.lock | ||