mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
d3202383c1
Summary: We have a couple of issues with the watchman/eden integration: 1. If you "win" the race, you can cause a segfault during shutdown by changing files during unmount. This causes the journal updating code to trigger a send to the client, but the associated eventBase has already been destroyed. 2. We don't proactively send any signal to the subscriber (in practice: watchman) when we unmount. Watchman detects the eden shutdown by noticing that its socket has closed but has no way to detect an unmount. This diff tries to connect the unmount with the set of subscribers and tries to cause the thrift socket to close out. Reviewed By: bolinfest Differential Revision: D6162717 fbshipit-source-id: 42d4a005089cd9cddf204997b1643570488f04c3 |
||
|---|---|---|
| .. | ||
| test | ||
| Journal.cpp | ||
| Journal.h | ||
| JournalDelta.cpp | ||
| JournalDelta.h | ||
| TARGETS | ||