mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 09:17:30 +03:00
6c71f5a3c0
Summary: There were a bunch of unused code warnings because the mutabledatapack module wasn't exposed as public. This then lead to us ignoring other warnings. Let's fix all of them. Reviewed By: quark-zju Differential Revision: D8895468 fbshipit-source-id: 914c81026469382fcf28015b4a6bce13bad746c2 |
||
---|---|---|
.. | ||
argparse | ||
cdatapack | ||
clib | ||
commitcloudsubscriber | ||
configparser | ||
hg_watchman_client | ||
indexedlog | ||
linelog | ||
lz4-pyframe | ||
minibench | ||
mpatch | ||
mpatch-sys | ||
pathencoding | ||
pathmatcher | ||
radixbuf | ||
revisionstore | ||
third-party | ||
treestate | ||
vlqencoding | ||
watchman_client | ||
zstdelta | ||
Cargo.toml | ||
README.md |
lib
Any native code (C/C++/Rust) that Mercurial (either core or extensions)
depends on should go here. Python code, or native code that depends on
Python code (e.g. #include <Python.h>
or use cpython
) is disallowed.
As we start to convert more of Mercurial into Rust, and write new paths entrirely in native code, we'll want to limit our dependency on Python, which is why this barrier exists.
See also hgext/extlib/README.md
, mercurial/cext/README.mb
.
How do I choose between lib
and extlib
(and cext
)?
If your code is native and doesn't depend on Python (awesome!), it goes here.
Otherwise, put it in hgext/extlib
(if it's only used by extensions) or
mercurial/cext
(if it's used by extensions or core).