sapling/eden
Xavier Deguillard d89eab8078 pyconfigparser: use String as arguments instead of PyBytes
Summary:
In the cpython bindings, the Rust String can take both PyBytes and PyUnicode
strings, which is perfect for Python3 compatibility as string literals are
PyBytes in Python2 and PyUnicode in Python3. The return values are kept as
Bytes for now as changing this is a much larger change in itself.

Other approaches tried:
 - Using PyUnicode as input/output: an extremely large codemod had to be done,
   with very little benefits
 - Using String as output: since we do have some configs that are unicode, on
   the Python side, the output might either be bytestrings or unicode, leading
   to weird bugs.

Reviewed By: DurhamG

Differential Revision: D18650466

fbshipit-source-id: aebdf30590dcae40b7df2787e5ece88e2ec9395c
2020-01-16 09:31:45 -08:00
..
benchmarks enable and fix more warnings 2019-12-20 16:14:17 -08:00
cli eden: du: revise instructions for cleaning up LFS 2020-01-15 12:31:56 -08:00
docs takeover documentation 2019-12-11 16:59:35 -08:00
fs Implemented check file name functionality to workaround a Projected FS issue. 2020-01-13 16:15:09 -08:00
integration reactivate test_abort_split_with_pending_add 2020-01-06 08:52:27 -08:00
locale add a copyright header to glibc_en.po 2019-04-26 14:38:27 -07:00
py Call WSAStartup and fix the type information for the socket APIs 2019-10-18 12:39:09 -07:00
scm pyconfigparser: use String as arguments instead of PyBytes 2020-01-16 09:31:45 -08:00
scripts Tidy up license headers 2019-10-11 05:28:23 -07:00
test_support Update pyre version for eden 2019-10-16 16:56:29 -07:00
test-data enable treemanifest in snapshots 2019-08-28 18:46:03 -07:00
third-party add osxfuse kernel header 2019-03-19 10:26:24 -07:00
win flip EDEN_WIN_NOMONONOKE to EDEN_HAVE_MONONOKE 2019-08-27 17:04:19 -07:00
.gitignore eden: wire up mac contbuild 2019-02-05 21:52:30 -08:00
Eden.project.toml Eden.project.toml file for Nuclide 2018-04-26 11:05:23 -07:00