mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 07:17:55 +03:00
e6737d409d
Summary: We need to introduce a new `includeDotfiles` option to `glob()`. [As we have done for all of our Thrift API, to date], rather than define `glob()` so that it takes a single struct, we specified the parameters individually, so we can no longer add new params to `glob()`. In particular, we need to support `includeDotfiles` because we often configure Buck to use Watchman to implement `glob()` in `BUCK` files, and when Watchman is used in Eden, it leverages Eden's Thrift API to implement `glob()`. Because Buck's `glob()` has an `include_dotfiles` option, we must be able to honor it and pass it all the way through to Eden's `glob()` implementation. Rather than name the new API `glob2()`, I'm electing to go with `globFiles()`. (Perhaps once we eliminate all known users of `glob()` in the wild, which requires turning over the current version of Watchman we have deployed, we can redefine `glob()` in `eden.thrift` to be the same as `globFiles()` and then update everyone to use `glob()` again so it has the more intuitive name.) Reviewed By: wez Differential Revision: D7748870 fbshipit-source-id: 92438f9c41e4fbdbd6cdccca5fce0e41cc3e9b07 |
||
|---|---|---|
| .. | ||
| hg | ||
| lib | ||
| basic_test.py | ||
| clone_test.py | ||
| debug_getpath_test.py | ||
| doteden_test.py | ||
| fsattr.cpp | ||
| glob_test.py | ||
| health_test.py | ||
| help_test.py | ||
| hypothesis_simple_test.py | ||
| info_test.py | ||
| materialized_query_test.py | ||
| mmap_test.py | ||
| oexcl_test.py | ||
| patch_test.py | ||
| persistence_test.py | ||
| rc_test.py | ||
| remount_test.py | ||
| rename_test.py | ||
| repo_test.py | ||
| sed_test.py | ||
| setattr_test.py | ||
| takeover_test.py | ||
| thrift_test.py | ||
| unixsocket_test.py | ||
| unlink_test.py | ||
| xattr_test.py | ||