mirror of
https://github.com/facebook/sapling.git
synced 2024-10-12 09:48:05 +03:00
584656dff3
Summary: Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`. Then run `arc lint` again so some other autofixers like spellchecker etc. looked at the code base. Manually accept the changes whenever they make sense, or use a workaround (ex. changing "dict()" to "dict constructor") where autofix is false positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less interesting to fix (hgsubversion tests), or cannot be fixed without breaking OSS build (FBPYTHON4). Conflicted linters (test-check-module-imports.t, part of test-check-code.t, test-check-pyflakes.t) are removed or disabled. Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed. An issue of the auto-formatter is lines are no longer guarnateed to be <= 80 chars. But that seems less important comparing with the benefit auto-formatter provides. As we're here, also remove test-check-py3-compat.t, as it is currently broken if `PYTHON3=/bin/python3` is set. Reviewed By: wez, phillco, simpkins, pkaush, singhsrb Differential Revision: D8173629 fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
50 lines
1.6 KiB
Python
50 lines
1.6 KiB
Python
# rewriteutil.py - utility functions for rewriting changesets
|
|
#
|
|
# Copyright 2017 Octobus <contact@octobus.net>
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2 or any later version.
|
|
|
|
from __future__ import absolute_import
|
|
|
|
from . import error, node, obsolete, revset
|
|
from .i18n import _
|
|
|
|
|
|
def precheck(repo, revs, action="rewrite"):
|
|
"""check if revs can be rewritten
|
|
action is used to control the error message.
|
|
|
|
Make sure this function is called after taking the lock.
|
|
"""
|
|
if node.nullrev in revs:
|
|
msg = _("cannot %s null changeset") % (action)
|
|
hint = _("no changeset checked out")
|
|
raise error.Abort(msg, hint=hint)
|
|
|
|
publicrevs = repo.revs("%ld and public()", revs)
|
|
if len(repo[None].parents()) > 1:
|
|
raise error.Abort(_("cannot %s while merging") % action)
|
|
|
|
if publicrevs:
|
|
msg = _("cannot %s public changesets") % (action)
|
|
hint = _("see 'hg help phases' for details")
|
|
raise error.Abort(msg, hint=hint)
|
|
|
|
newunstable = disallowednewunstable(repo, revs)
|
|
if newunstable:
|
|
raise error.Abort(_("cannot %s changeset with children") % action)
|
|
|
|
|
|
def disallowednewunstable(repo, revs):
|
|
"""Checks whether editing the revs will create new unstable changesets and
|
|
are we allowed to create them.
|
|
|
|
To allow new unstable changesets, set the config:
|
|
`experimental.evolution.allowunstable=True`
|
|
"""
|
|
allowunstable = obsolete.isenabled(repo, obsolete.allowunstableopt)
|
|
if allowunstable:
|
|
return revset.baseset()
|
|
return repo.revs("(%ld::) - %ld", revs, revs)
|