mirror of
https://github.com/facebook/sapling.git
synced 2024-10-08 07:49:11 +03:00
e0227f8c4e
Summary: While debugging SRProxy issue I found a bug in ThriftServer initialization (more details in D6115379), due to that bug we always have accept queue of 1k and the value passed to `setMaxNumPendingConnectionsPerWorker` is ignored, thus making all call sites bogus. We have ~350 calls to this function in fbcode, all of them pass random numbers such as 50, 100, 50k, etc. I’m removing all of them before landing the fix for Thrift to avoid causing production issues. Unfortunately almost every such caller has a gflag for it (that are usually have confusing names, e.g. FLAGS_thriftSetMaxNumMessagesInQueue). I’m not touching these gflags, because they may be used in different configs and removing them would cause breakages. Reviewed By: yfeldblum Differential Revision: D6129569 fbshipit-source-id: 1550b5073bac42d0c6fb7bdffa1835bf523609c8 |
||
---|---|---|
.. | ||
oss | ||
__init__.py | ||
client.py | ||
DEFS | ||
eden.thrift | ||
EdenError.cpp | ||
EdenError.h | ||
EdenServer.cpp | ||
EdenServer.h | ||
EdenServiceHandler.cpp | ||
EdenServiceHandler.h | ||
GlobNode.cpp | ||
GlobNode.h | ||
main.cpp | ||
PrettyPrinters.cpp | ||
PrettyPrinters.h | ||
streamingeden.thrift | ||
StreamingSubscriber.cpp | ||
StreamingSubscriber.h | ||
TARGETS | ||
ThriftUtil.h |