mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 08:18:15 +03:00
163b35ec2e
Summary: D6685044 changed the location of fastmanifest which exposed it to the additional test that failed. This commit fixes fastmanifest to address that test. Test Plan: Ran all the tests. Reviewers: #mercurial, #sourcecontrol Differential Revision: https://phabricator.intern.facebook.com/D6685170
237 lines
13 KiB
Perl
237 lines
13 KiB
Perl
#require test-repo
|
|
|
|
$ . "$TESTDIR/helpers-testrepo.sh"
|
|
$ check_code="$TESTDIR"/../contrib/check-code.py
|
|
$ cd "$TESTDIR"/..
|
|
|
|
New errors are not allowed. Warnings are strongly discouraged.
|
|
(The writing "no-che?k-code" is for not skipping this file when checking.)
|
|
|
|
$ testrepohg locate \
|
|
> -X contrib/python-zstandard \
|
|
> -X hgext/fsmonitor/pywatchman \
|
|
> -X lib/cdatapack \
|
|
> -X lib/third-party \
|
|
> -X mercurial/thirdparty \
|
|
> -X fb-hgext \
|
|
> | sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
|
|
Skipping hgext/extlib/cfastmanifest.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/bsearch.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/bsearch.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/bsearch_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/checksum.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/checksum.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/checksum_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/internal_result.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/node.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/node.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/node_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/path_buffer.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/result.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tests.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tests.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_arena.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_arena.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_convert.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_convert_rt.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_convert_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_copy.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_copy_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_diff.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_diff_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_disk.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_disk_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_dump.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_iterate_rt.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_iterator.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_iterator.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_iterator_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_path.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_path.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cfastmanifest/tree_test.c it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/datapackstore.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/datapackstore.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/datastore.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/deltachain.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/deltachain.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/key.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/match.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/py-cdatapack.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/py-cstore.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/py-datapackstore.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/py-structs.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/py-treemanifest.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/pythondatastore.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/pythondatastore.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/pythonkeyiterator.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/pythonutil.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/pythonutil.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/store.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/uniondatapackstore.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/cstore/uniondatapackstore.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest_entry.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest_entry.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest_fetcher.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest_fetcher.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest_ptr.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/manifest_ptr.h it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/treemanifest.cpp it has no-che?k-code (glob)
|
|
Skipping hgext/extlib/ctreemanifest/treemanifest.h it has no-che?k-code (glob)
|
|
hgext/fastannotate/commands.py:43:
|
|
> reldir = os.path.relpath(os.getcwd(), reporoot)
|
|
use pycompat.getcwd instead (py3)
|
|
hgext/fbsparse.py:1177:
|
|
> cwd = util.normpath(os.getcwd())
|
|
use pycompat.getcwd instead (py3)
|
|
Skipping hgext/hgsql.py it has no-che?k-code (glob)
|
|
hgext/morestatus.py:49:
|
|
> os.getcwd()) for path in unresolvedlist])
|
|
use pycompat.getcwd instead (py3)
|
|
hgext/phabstatus.py:78:
|
|
> repodir=os.getcwd(), ca_bundle=ca_certs, repo=repo)
|
|
use pycompat.getcwd instead (py3)
|
|
hgext/treedirstate.py:674:
|
|
> if 'CHGINTERNALMARK' in os.environ:
|
|
use encoding.environ instead (py3)
|
|
hgext/tweakdefaults.py:275:
|
|
> if pipei_bufsize != 4096 and os.name == 'nt':
|
|
use pycompat.osname instead (py3)
|
|
hgext/undo.py:71:
|
|
> if 'CHGINTERNALMARK' in os.environ:
|
|
use encoding.environ instead (py3)
|
|
hgext/undo.py:89:
|
|
> if '_undologactive' in os.environ:
|
|
use encoding.environ instead (py3)
|
|
hgext/undo.py:97:
|
|
> os.environ['_undologactive'] = "active"
|
|
use encoding.environ instead (py3)
|
|
hgext/undo.py:127:
|
|
> del os.environ['_undologactive']
|
|
use encoding.environ instead (py3)
|
|
Skipping hgsubversion/hgsubversion/__init__.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/compathacks.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/editor.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/hooks/updatemeta.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/layouts/base.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/layouts/custom.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/layouts/standard.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/maps.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/pushmod.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/stupid.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svncommands.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svnexternals.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svnmeta.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svnrepo.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svnwrap/__init__.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svnwrap/common.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svnwrap/subvertpy_wrapper.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/svnwrap/svn_swig_wrapper.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/util.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/verify.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/hgsubversion/wrappers.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/setup.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/comprehensive/test_custom_layout.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/comprehensive/test_obsstore_on.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/comprehensive/test_rebuildmeta.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/comprehensive/test_sqlite_revmap.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/comprehensive/test_stupid_pull.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/comprehensive/test_updatemeta.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/comprehensive/test_verify_and_startrev.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/fixtures/rsvn.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/run.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_externals.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_fetch_branches.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_fetch_command.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_fetch_command_regexes.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_fetch_exec.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_fetch_mappings.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_fetch_symlinks.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_push_command.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_push_dirs.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_push_renames.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_single_dir_clone.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_single_dir_push.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_svn_pre_commit_hooks.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_svnwrap.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_tags.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_template_keywords.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_urls.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_util.py it has no-che?k-code (glob)
|
|
Skipping hgsubversion/tests/test_utility_commands.py it has no-che?k-code (glob)
|
|
Skipping i18n/polib.py it has no-che?k-code (glob)
|
|
Skipping lib/clib/buffer.c it has no-che?k-code (glob)
|
|
Skipping lib/clib/buffer.h it has no-che?k-code (glob)
|
|
Skipping lib/clib/convert.h it has no-che?k-code (glob)
|
|
Skipping lib/clib/null_test.c it has no-che?k-code (glob)
|
|
Skipping lib/clib/portability/inet.h it has no-che?k-code (glob)
|
|
Skipping lib/clib/portability/portability.h it has no-che?k-code (glob)
|
|
Skipping lib/clib/portability/unistd.h it has no-che?k-code (glob)
|
|
Skipping lib/clib/sha1.h it has no-che?k-code (glob)
|
|
Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
|
|
Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
|
|
Skipping mercurial/statprof.py it has no-che?k-code (glob)
|
|
Skipping tests/badserverext.py it has no-che?k-code (glob)
|
|
Skipping tests/conduithttp.py it has no-che?k-code (glob)
|
|
tests/test-fb-hgext-myparent.t:56:
|
|
> $ hg help templates | grep -A2 myparent
|
|
don't use grep's context flags
|
|
tests/test-fb-hgext-rage.t:10:
|
|
> $ echo "rpmbin = /bin/rpm" >> .hg/hgrc
|
|
don't use explicit paths for tools
|
|
Skipping tests/test-fb-hgext-remotefilelog-bad-configs.t it has no-che?k-code (glob)
|
|
tests/test-fb-hgext-smartlog.t:483:
|
|
> $ hg help templates | egrep -A2 '(amend|fold|histedit|rebase|singlepublic|split|undo)'successor
|
|
don't use grep's context flags
|
|
tests/test-hggit-git-submodules.t:61:
|
|
> $ grep 'submodule "subrepo2"' -A2 .gitmodules > .gitmodules-new
|
|
don't use grep's context flags
|
|
tests/test-hggit-gitignore.t:124:
|
|
> $ echo 'foo.*$(?<!bar)' >> .hgignore
|
|
don't use $(expr), use `expr`
|
|
tests/test-hggit-renames.t:79:
|
|
> $ grep 'submodule "gitsubmodule"' -A2 .gitmodules > .gitmodules-new
|
|
don't use grep's context flags
|
|
Skipping tests/test-hgsql-encoding.t it has no-che?k-code (glob)
|
|
Skipping tests/test-hgsql-race-conditions.t it has no-che?k-code (glob)
|
|
[1]
|
|
|
|
@commands in debugcommands.py should be in alphabetical order.
|
|
|
|
>>> import re
|
|
>>> commands = []
|
|
>>> with open('mercurial/debugcommands.py', 'rb') as fh:
|
|
... for line in fh:
|
|
... m = re.match("^@command\('([a-z]+)", line)
|
|
... if m:
|
|
... commands.append(m.group(1))
|
|
>>> scommands = list(sorted(commands))
|
|
>>> for i, command in enumerate(scommands):
|
|
... if command != commands[i]:
|
|
... print('commands in debugcommands.py not sorted; first differing '
|
|
... 'command is %s; expected %s' % (commands[i], command))
|
|
... break
|
|
|
|
Prevent adding new files in the root directory accidentally.
|
|
|
|
$ testrepohg files 'glob:*'
|
|
.arcconfig
|
|
.clang-format
|
|
.editorconfig
|
|
.hgignore
|
|
.hgsigs
|
|
.hgtags
|
|
.jshintrc
|
|
CONTRIBUTING
|
|
CONTRIBUTORS
|
|
COPYING
|
|
Makefile
|
|
README.rst
|
|
hg
|
|
hgeditor
|
|
hgweb.cgi
|
|
setup.py
|