mirror of
https://github.com/facebook/sapling.git
synced 2024-10-08 15:57:43 +03:00
0273817488
Summary: The StringConv.h header contains many functions to convert from Windows paths to Eden's path (and vice versa) to workaround the fact that Eden's path don't support wide strings that Windows uses. Let's simply add support for these wide strings in PathFuncs so we can greatly simplify all the call sites. Instead of calling "edenToWinName(winstr)", "PathComponent(winstr)" is both more descriptive and more idiomatic. To be fair, I'm not entirely a fan of the approach taken in this diff, as this adds Windows specific code to PathFuncs.h, but I feel that the benefit is too big to not do that. Reviewed By: chadaustin Differential Revision: D23004523 fbshipit-source-id: 3a1507e398a66909773251907db01e06603b91dd |
||
|---|---|---|
| .. | ||
| test | ||
| CMakeLists.txt | ||
| FileUtils.cpp | ||
| FileUtils.h | ||
| Guid.h | ||
| Handle.h | ||
| Pipe.cpp | ||
| Pipe.h | ||
| StringConv.h | ||
| Stub.h | ||
| Subprocess.cpp | ||
| Subprocess.h | ||
| WinError.cpp | ||
| WinError.h | ||