sapling/eden/fs/service
Richard Barnes bd3aa77356 Fix shadowed variable in eden/fs/service/EdenServiceHandler.cpp
Summary:
Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.

This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.

**What's a shadowed variable?**

Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.

This diff fixes such an issue by renaming the variable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D53478940

fbshipit-source-id: da0e0a0043f87fa27599ec051c3c772eba0721d4
2024-02-06 16:37:12 -08:00
..
clients Regenerate thrift_build.rs with labels 2024-02-03 06:25:38 -08:00
oss oss: remove Windows specific try/catch 2022-11-03 11:37:39 -07:00
services Regenerate thrift_build.rs with labels 2024-02-03 06:25:38 -08:00
test Remove explicit key 2023-12-04 10:03:02 -08:00
thrift_streaming Regenerate thrift_build.rs with labels 2024-02-03 06:25:38 -08:00
types Regenerate thrift_build.rs with labels 2024-02-03 06:25:38 -08:00
.gitignore watchman: pull in thrift in the oss build for eden support 2019-02-04 21:37:47 -08:00
Cargo.toml Disable Cargo documentation generation for Thrift targets 2024-02-02 07:45:58 -08:00
CMakeLists.txt fix getdeps build on Windows 2023-07-25 15:24:16 -07:00
eden.thrift fbcode/eden/ 2023-11-14 19:37:41 -08:00
EdenCPUThreadPool.cpp gflags: codemod our use of gflags to use folly/portability/GFlags.h 2022-06-16 13:43:57 -07:00
EdenCPUThreadPool.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
EdenInit.cpp allow consumption of /etc/eden/edenfs_cfgr.rc 2023-10-19 17:22:48 -07:00
EdenInit.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
EdenMain.cpp refactor FilteredBackingStore creation 2023-11-30 13:29:50 -08:00
EdenMain.h Add a possibility to configure the default blake3 key value 2023-06-23 14:58:01 -07:00
EdenServer.cpp support cloning a FilteredFS repo 2023-11-30 13:29:50 -08:00
EdenServer.h inodes: remove remaining QueuedImmediateExecutor from EdenMount 2023-11-07 11:18:21 -08:00
EdenServiceHandler.cpp Fix shadowed variable in eden/fs/service/EdenServiceHandler.cpp 2024-02-06 16:37:12 -08:00
EdenServiceHandler.h service: use VirtualInodeLoader for getBlake3 Thrift call 2023-10-23 09:47:08 -07:00
EdenStateDir.cpp better error message when eden fails to start flock 2023-12-06 15:21:09 -08:00
EdenStateDir.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
PeriodicTask.cpp break PeriodicTask's dependency on EdenServer 2023-05-11 15:06:37 -07:00
PeriodicTask.h break PeriodicTask's dependency on EdenServer 2023-05-11 15:06:37 -07:00
PrettyPrinters.cpp standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
PrettyPrinters.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
PrivHelperMain.cpp privhelper is no longer FUSE-specific, so move it to fs/ 2023-05-11 18:29:21 -07:00
StartupLogger.cpp eden (-8536898070263054920) 2023-10-14 03:37:10 -07:00
StartupLogger.h expose startup status on thrift server 2023-01-27 15:48:56 -08:00
StartupStatusSubscriber.cpp create StartupStatusSubscriber 2022-12-09 11:42:07 -08:00
StartupStatusSubscriber.h create StartupStatusSubscriber 2022-12-09 11:42:07 -08:00
streamingeden.thrift bridge to mercurial for partial glob matching 2024-01-19 09:15:08 -08:00
TARGETS bridge to mercurial for partial glob matching 2024-01-19 09:15:08 -08:00
thrift_build.rs Regenerate thrift_build.rs with labels 2024-02-03 06:25:38 -08:00
thrift_lib.rs move autocargo up one level (#101) 2022-02-08 06:07:52 -08:00
ThriftGetObjectImpl.cpp rename getBlobFromOrigin 2023-01-27 14:35:09 -08:00
ThriftGetObjectImpl.h rename getBlobFromOrigin 2023-01-27 14:35:09 -08:00
ThriftGlobImpl.cpp fully separate GlobNode and GlobTree 2023-10-10 14:54:13 -07:00
ThriftGlobImpl.h fully separate GlobNode and GlobTree 2023-10-10 14:54:13 -07:00
ThriftPermissionChecker.cpp standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
ThriftPermissionChecker.h standardize namespaces on C++17 syntax 2022-05-17 10:12:56 -07:00
ThriftStreamStartupStatusSubscriber.cpp introduce ThriftStreamStartupStatusSubscriber 2023-01-03 11:02:09 -08:00
ThriftStreamStartupStatusSubscriber.h introduce ThriftStreamStartupStatusSubscriber 2023-01-03 11:02:09 -08:00
ThriftUtil.cpp remove all but one inclusion of folly/String.h in headers 2023-05-11 11:10:01 -07:00
ThriftUtil.h ThriftUtil to support blake3 2023-06-05 23:41:35 -07:00
UsageService.cpp clang-tidy advice 2023-07-13 16:30:55 -07:00
UsageService.h remove some ifdefs by introducing a platform-independent UsageService class 2023-05-17 19:16:48 -07:00