sapling/eden
Adam Simpkins e93e9b3531 fix some exceptions thrown by FsOverlay
Summary:
Update `FsOverlay::validateHeader()` to throw `EdenError` exceptions rather
than `std::system_error`.  These exceptions are generated when we find invalid
data, rather than from system calls that return errno values.  Previously the
code was using `folly::throwSystemErrorExplicit()` and
`folly:throwSystemError()`, and passing in a made-up `EIO` value.

However, the latter two calls were incorrectly using
`folly::throwSystemError()` rather than `throwSystemErrorExplicit()`.  As a
result the `EIO` parameter was being treated as part of the error message, and
the code was appending the error description for whatever value `errno`
happened to be set to at the moment.

This fixes the code to just throw `EdenError` exception types, since these
errors aren't caused by a real `errno` value.

Reviewed By: strager

Differential Revision: D16577698

fbshipit-source-id: 9487c34f04da99d397611f005f00f02114b12094
2019-07-31 13:53:58 -07:00
..
benchmarks update license headers in C++ files 2019-06-19 17:02:45 -07:00
cli Add debug command to flush Journal 2019-07-30 22:05:32 -07:00
docs Document how globs work 2019-03-07 14:20:57 -08:00
fs fix some exceptions thrown by FsOverlay 2019-07-31 13:53:58 -07:00
integration use fb303 repo in open source build 2019-07-24 21:07:04 -07:00
locale add a copyright header to glibc_en.po 2019-04-26 14:38:27 -07:00
py use fb303 repo in open source build 2019-07-24 21:07:04 -07:00
scripts update license header in remaining files 2019-06-19 17:02:46 -07:00
test_support update license headers in .py files 2019-06-19 17:02:46 -07:00
test-data generate a new version of the "basic" snapshot 2019-03-18 11:36:42 -07:00
third-party add osxfuse kernel header 2019-03-19 10:26:24 -07:00
win Kill legacySubscribe method for establishing streams 2019-06-24 11:06:22 -07:00
.gitignore eden: wire up mac contbuild 2019-02-05 21:52:30 -08:00
Eden.project.toml Eden.project.toml file for Nuclide 2018-04-26 11:05:23 -07:00