mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 00:14:35 +03:00
0af2511a3f
Summary: The goal of this stack is to remove Proxy Hash type, but to achieve that we need first to address some tech debt in Eden codebase. For the long time EdenFs had single Hash type that was used for many different use cases. One of major uses for Hash type is identifies internal EdenFs objects such as blobs, trees, and others. We seem to reach agreement that we need a different type for those identifiers, so we introduce separate ObjectId type in this diff to denote new identifier type and replace _some_ usage of Hash with ObjectId. We still retain original Hash type for other use cases. Roughly speaking, this is how this diff separates between Hash and ObjectId: **ObjectId**: * Everything that is stored in local store(blobs, trees, commits) **Hash20**: * Explicit hashes(Sha1 of the blob) * Hg identifiers: manifest id and blob hg ig For now, in this diff ObjectId has exactly same content as Hash, but this will change in the future diffs. Doing this way allows to keep diff size manageable, while migrating to new ObjectId right away would produce insanely large diff that would be both hard to make and review. There are few more things that needs to be done before we can get to the meat of removing proxy hashes: 1) Replace include Hash.h with ObjectId.h where needed 2) Remove Hash type, explicitly rename rest of Hash usages to Hash20 3) Modify content of ObjectId to support new use cases 4) Modify serialized metadata and possibly other places that assume ObjectId size is fixed and equal to Hash20 size Reviewed By: chadaustin Differential Revision: D31316477 fbshipit-source-id: 0d5e4460a461bcaac6b9fd884517e129aeaf4baf |
||
|---|---|---|
| .. | ||
| fsck | ||
| helpers | ||
| hg | ||
| lib | ||
| snapshot | ||
| basic_test.py | ||
| casing_test.py | ||
| chown_test.py | ||
| clone_test.py | ||
| CMakeLists.txt | ||
| config_test.py | ||
| corrupt_overlay_test.py | ||
| debug_getpath_test.py | ||
| debug_test.py | ||
| doteden_test.py | ||
| edenclient_test.py | ||
| fsck_test.py | ||
| glob_test.py | ||
| health_test.py | ||
| help_test.py | ||
| info_test.py | ||
| linux_cgroup_test.py | ||
| materialized_query_test.py | ||
| mmap_test.py | ||
| mount_test.py | ||
| oexcl_test.py | ||
| patch_test.py | ||
| persistence_test.py | ||
| rage_test.py | ||
| rc_test.py | ||
| redirect_test.py | ||
| remount_test.py | ||
| rename_test.py | ||
| restart_test.py | ||
| rocksdb_store_test.py | ||
| sed_test.py | ||
| service_log_test.py | ||
| setattr_test.py | ||
| stale_inode_test.py | ||
| stale_test.py | ||
| start_test.py | ||
| stats_test.py | ||
| stop_test.py | ||
| systemd_test.py | ||
| takeover_test.py | ||
| thrift_test.py | ||
| unicode_test.py | ||
| unixsocket_test.py | ||
| unlink_test.py | ||
| userinfo_test.py | ||
| windows_fsck_test.py | ||
| xattr_test.py | ||