sapling/ctreemanifest
Durham Goode 10f743a300 treemanifest: chop off trailing slash when requesting manifests
Summary:
The name being passed to the store was wrong, because it had a trailing slash.
This wasn't caught before because the code was reading and writing the paths
with a slash at the end, so it matched as long as we only interacted with packs
produced by the code. The issue became more obvious when I tried to have packs
generated from revlogs interact with this code.

All the tests are affected since the entry keys changed.

Also use 'const ManifestFetcher &x' to pass the ref to avoid the copy.

Test Plan: Tests updated

Reviewers: #mercurial, quark

Reviewed By: quark

Subscribers: quark, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D4901274

Signature: t1:4901274:1492638476:ff28f8976657baec99effbd82ecd436f6282ea5b
2017-04-19 21:14:04 -07:00
..
convert.h treemanifest: remove accidental use of '\0' * 40 2017-04-19 21:14:04 -07:00
manifest_entry.cpp treemanifest: chop off trailing slash when requesting manifests 2017-04-19 21:14:04 -07:00
manifest_entry.h treemanifest: chop off trailing slash when requesting manifests 2017-04-19 21:14:04 -07:00
manifest_fetcher.cpp treemanifest: move manifest node onto Manifest 2017-04-19 21:14:03 -07:00
manifest_fetcher.h ctreemanifest: remove PythonObj from manifest data structures 2017-02-23 14:03:03 -08:00
manifest.cpp treemanifest: fix serialization during walksubtree of non-finalized trees 2017-04-19 21:14:04 -07:00
manifest.h treemanifest: refactor finalizing logic out of subtreeiter 2017-04-19 21:14:03 -07:00
treemanifest.cpp treemanifest: chop off trailing slash when requesting manifests 2017-04-19 21:14:04 -07:00
treemanifest.h treemanifest: remove accidental use of '\0' * 40 2017-04-19 21:14:04 -07:00