sapling/eden
Stanislau Hlebik eb55bb4284 mononoke: make sure multiplexed blobstore write succeeds if all underlying
Summary:
We had somewhat inconsistent behaviour in multiplexed blobstore:
1) If on_put handlers are too slow (i.e. they are slower than all blobstores) then we
succeed as soon as all blobstores were successful (regardless of the value of
minimum_successful_writes). It doesn't matter if on_put handlers fail or
succeed, we've already returned success to our user.
2) However if all writes to the queue quickly fail, then we return a failure
even if writes to all blobstore were successful.

#2 seems like a change in behaviour from an old diff D17421208 (9de1de2d8b), and not a
desirable one - if blobstore sync queue is unavailable and it responds with
failures quickly, then blobstore writes will always fail even if all blobstores
are healthy.

So this diff makes it so that we always succeed if all blobstore puts were
successful, regardless of success or failures of on_put handlers.

Reviewed By: liubov-dmitrieva

Differential Revision: D29985084

fbshipit-source-id: 64338d552be45a70d9b1d16dfbe7d10346ab539c
2021-07-29 08:37:53 -07:00
..
fs inodes: remove unused statement 2021-07-28 19:00:52 -07:00
hg-server Remove target-based type checking in eden 2021-07-23 12:34:20 -07:00
integration integration: fix pull_test with getdeps 2021-07-27 16:16:30 -07:00
locale
mononoke mononoke: make sure multiplexed blobstore write succeeds if all underlying 2021-07-29 08:37:53 -07:00
scm fix debughiddencommit command for LFS 2021-07-29 02:03:57 -07:00
test_support fix systemd tests locally 2021-07-09 17:24:11 -07:00
test-data fix fsck snapshot integration tests 2021-07-14 16:20:04 -07:00
.gitignore
Eden.project.toml Eden.project.toml file for Nuclide 2018-04-26 11:05:23 -07:00