mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
e4dab84619
Summary: This diff prepares the Mononoke codebase for composition-based extendability of `ScubaSampleBuilder`. Specifically, in the near future I will add: - new methods for verbose scuba logging - new data field (`ObservabilityContext`) to check if verbose logging should be enabled or disabled The higher-level goal here is to be able to enable/disable verbose Scuba logging (either overall or for certain slices of logs, like for a certain session id) in real time, without restarting Mononoke. To do so, I plan to expose the aforementioned verbose logging methods, which will run a check against the stored `ObservabilityContext` and make a decision of whether the logging is enabled or not. `ObservabilityContext` will of course hide implementation details from the renamed `ScubaSampleBuilderExt`, and just provide a yes/no answer based on the current config and sample fields. At the moment this should be a completely harmless change. Reviewed By: krallin Differential Revision: D25211089 fbshipit-source-id: ea03dda82fadb7fc91a2433e12e220582ede5fb8 |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |