mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 16:31:02 +03:00
63cc76d3b4
As discussed on the list, we are adding an official way to keep old API around for a short time in order to help third party developer to catch up. The deprecated API will issue developer warning (issued by default during test runs) to warn extensions authors that they need to upgrade their code without instantaneously breaking tool chains and normal users. The version is passed as an explicit argument so that developer think about it and a potential future script can automatically check for it. This is not build as a decorator because accessing the 'ui' instance will likely be different each time. The message is also free form because deprecated API are replaced in a variety of ways. I'm not super happy about the final rendering of that message, but this is a developer oriented warning and I would like to move forward.
142 lines
4.7 KiB
Perl
142 lines
4.7 KiB
Perl
|
|
$ cat << EOF > buggylocking.py
|
|
> """A small extension that tests our developer warnings
|
|
> """
|
|
>
|
|
> from mercurial import cmdutil, repair, revset
|
|
>
|
|
> cmdtable = {}
|
|
> command = cmdutil.command(cmdtable)
|
|
>
|
|
> @command('buggylocking', [], '')
|
|
> def buggylocking(ui, repo):
|
|
> tr = repo.transaction('buggy')
|
|
> lo = repo.lock()
|
|
> wl = repo.wlock()
|
|
> wl.release()
|
|
> lo.release()
|
|
>
|
|
> @command('properlocking', [], '')
|
|
> def properlocking(ui, repo):
|
|
> """check that reentrance is fine"""
|
|
> wl = repo.wlock()
|
|
> lo = repo.lock()
|
|
> tr = repo.transaction('proper')
|
|
> tr2 = repo.transaction('proper')
|
|
> lo2 = repo.lock()
|
|
> wl2 = repo.wlock()
|
|
> wl2.release()
|
|
> lo2.release()
|
|
> tr2.close()
|
|
> tr.close()
|
|
> lo.release()
|
|
> wl.release()
|
|
>
|
|
> @command('nowaitlocking', [], '')
|
|
> def nowaitlocking(ui, repo):
|
|
> lo = repo.lock()
|
|
> wl = repo.wlock(wait=False)
|
|
> wl.release()
|
|
> lo.release()
|
|
>
|
|
> @command('stripintr', [], '')
|
|
> def stripintr(ui, repo):
|
|
> lo = repo.lock()
|
|
> tr = repo.transaction('foobar')
|
|
> try:
|
|
> repair.strip(repo.ui, repo, [repo['.'].node()])
|
|
> finally:
|
|
> lo.release()
|
|
> @command('oldanddeprecated', [], '')
|
|
> def oldanddeprecated(ui, repo):
|
|
> """test deprecation warning API"""
|
|
> def foobar(ui):
|
|
> ui.deprecwarn('foorbar is deprecated, go shopping', '42.1337')
|
|
> foobar(ui)
|
|
>
|
|
> def oldstylerevset(repo, subset, x):
|
|
> return list(subset)
|
|
>
|
|
> revset.symbols['oldstyle'] = oldstylerevset
|
|
> EOF
|
|
|
|
$ cat << EOF >> $HGRCPATH
|
|
> [extensions]
|
|
> buggylocking=$TESTTMP/buggylocking.py
|
|
> [devel]
|
|
> all-warnings=1
|
|
> EOF
|
|
|
|
$ hg init lock-checker
|
|
$ cd lock-checker
|
|
$ hg buggylocking
|
|
devel-warn: transaction with no lock at: $TESTTMP/buggylocking.py:* (buggylocking) (glob)
|
|
devel-warn: "wlock" acquired after "lock" at: $TESTTMP/buggylocking.py:* (buggylocking) (glob)
|
|
$ cat << EOF >> $HGRCPATH
|
|
> [devel]
|
|
> all=0
|
|
> check-locks=1
|
|
> EOF
|
|
$ hg buggylocking
|
|
devel-warn: transaction with no lock at: $TESTTMP/buggylocking.py:* (buggylocking) (glob)
|
|
devel-warn: "wlock" acquired after "lock" at: $TESTTMP/buggylocking.py:* (buggylocking) (glob)
|
|
$ hg buggylocking --traceback
|
|
devel-warn: transaction with no lock at:
|
|
*/hg:* in * (glob)
|
|
*/mercurial/dispatch.py:* in run (glob)
|
|
*/mercurial/dispatch.py:* in dispatch (glob)
|
|
*/mercurial/dispatch.py:* in _runcatch (glob)
|
|
*/mercurial/dispatch.py:* in _dispatch (glob)
|
|
*/mercurial/dispatch.py:* in runcommand (glob)
|
|
*/mercurial/dispatch.py:* in _runcommand (glob)
|
|
*/mercurial/dispatch.py:* in checkargs (glob)
|
|
*/mercurial/dispatch.py:* in <lambda> (glob)
|
|
*/mercurial/util.py:* in check (glob)
|
|
$TESTTMP/buggylocking.py:* in buggylocking (glob)
|
|
devel-warn: "wlock" acquired after "lock" at:
|
|
*/hg:* in * (glob)
|
|
*/mercurial/dispatch.py:* in run (glob)
|
|
*/mercurial/dispatch.py:* in dispatch (glob)
|
|
*/mercurial/dispatch.py:* in _runcatch (glob)
|
|
*/mercurial/dispatch.py:* in _dispatch (glob)
|
|
*/mercurial/dispatch.py:* in runcommand (glob)
|
|
*/mercurial/dispatch.py:* in _runcommand (glob)
|
|
*/mercurial/dispatch.py:* in checkargs (glob)
|
|
*/mercurial/dispatch.py:* in <lambda> (glob)
|
|
*/mercurial/util.py:* in check (glob)
|
|
$TESTTMP/buggylocking.py:* in buggylocking (glob)
|
|
$ hg properlocking
|
|
$ hg nowaitlocking
|
|
|
|
$ echo a > a
|
|
$ hg add a
|
|
$ hg commit -m a
|
|
$ hg stripintr
|
|
saved backup bundle to $TESTTMP/lock-checker/.hg/strip-backup/*-backup.hg (glob)
|
|
abort: programming error: cannot strip from inside a transaction
|
|
(contact your extension maintainer)
|
|
[255]
|
|
|
|
$ hg log -r "oldstyle()" -T '{rev}\n'
|
|
devel-warn: revset "oldstyle" use list instead of smartset, (upgrade your code) at: */mercurial/revset.py:* (mfunc) (glob)
|
|
0
|
|
$ hg oldanddeprecated
|
|
devel-warn: foorbar is deprecated, go shopping
|
|
(compatibility will be dropped after Mercurial-42.1337, update your code.) at: $TESTTMP/buggylocking.py:* (oldanddeprecated) (glob)
|
|
|
|
$ hg oldanddeprecated --traceback
|
|
devel-warn: foorbar is deprecated, go shopping
|
|
(compatibility will be dropped after Mercurial-42.1337, update your code.) at:
|
|
*/hg:* in <module> (glob)
|
|
*/mercurial/dispatch.py:* in run (glob)
|
|
*/mercurial/dispatch.py:* in dispatch (glob)
|
|
*/mercurial/dispatch.py:* in _runcatch (glob)
|
|
*/mercurial/dispatch.py:* in _dispatch (glob)
|
|
*/mercurial/dispatch.py:* in runcommand (glob)
|
|
*/mercurial/dispatch.py:* in _runcommand (glob)
|
|
*/mercurial/dispatch.py:* in checkargs (glob)
|
|
*/mercurial/dispatch.py:* in <lambda> (glob)
|
|
*/mercurial/util.py:* in check (glob)
|
|
$TESTTMP/buggylocking.py:* in oldanddeprecated (glob)
|
|
$ cd ..
|