facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 15:27:13 +03:00
Code Issues Projects Releases Wiki Activity
ee2c0f2cff
sapling/common
History
Joseph Wu 6169d8c059 rename link_state_down to link_state_flap 
Summary:
In this diff, the main goal is to change the old `link_state.down` to `link_state.flap`. However, the tricky part is how can we use the normalized
portName(ethX/Y/Z) instead of portX as the key name. Since, the initialization of wedge_agent will go through two stage genrally:
In such case, we need to support changing the portName for PortStats after it's created.

My last diff(D5695076) is trying to delete all the TLTimeseries of all the threads in PortUpdateHandler observer, while ThreadLocalStats will also
try to unregister(delete) the TLTimeseries before we shut down wedge_agent. Therefore, we saw this:
```
Sep 16 19:09:52 rsw1fs.17.prn2.facebook.com wedge_agent[1884398]: F0916 19:09:52.716562 1884650 ThreadLocalStats-defs.h:495] Check failed: numErased == 1 attempted to unregister a stat that was not registered
```

So I guess probably it's not a good idea to delete a TLTimeseries of some thread in a different thread, unless you can get the global lock like ThreadLocalStats
does. Thus, in this new diff, I kinda walk around it:

Differential Revision: D5914457

fbshipit-source-id: f7d47d2ececfabbab8fdc222a0f82db4184230f9
2017-10-09 10:36:47 -07:00
..
fb303 codemod: format TARGETS with buildifier [3/5] (D5092623) 2017-06-01 16:51:16 -07:00
network/if Do not set default value for ifName 2017-04-21 22:49:35 -07:00
stats rename link_state_down to link_state_flap 2017-10-09 10:36:47 -07:00
README.md Add fb303 stubs in common/ to support building in the opensource repo 2017-03-17 17:08:05 -07:00

README.md

This directory mostly contains stub implementations of Facebook libraries that are not fully open source yet. These stubs allow the FBOSS code to build while we are still working on fully open sourcing these libraries.

The code in common/stats is the main piece that is not fully open source yet. We are working to eventually make all of this code available in the facebook/folly repository.