mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
de7f624497
Summary: `target_link_libraries` only allows passing things that are libraries and expressly forbids passing in `-framework Foo`, which is the sort of thing we get back from pkg-config on macos. The result of misusing this is that cmake would add `["-framework", "-lFoo"]` to the argv for the linker, which is totally broken. Instead, we should use `target_link_options`. Unfortunately, cmake seems to fail to do the right thing with the ` -framework CoreFoundation -framework Security` flags returned from libgit2 on my system even using `target_link_options`; it somehow ends up with a bare `Security` and fails to link. meh. Reviewed By: strager Differential Revision: D14680672 fbshipit-source-id: 62f65ddb4d07c8194cfc453cef1349b01be6c8b3 |
||
|---|---|---|
| .. | ||
| CompilerSettingsUnix.cmake | ||
| eden-config.h.in | ||
| EdenConfigChecks.cmake | ||
| FBMercurialFeatures.cmake | ||
| Findcpptoml.cmake | ||
| FindGMock.cmake | ||
| FindLibGit2.cmake | ||
| FindLZ4.cmake | ||
| FindSELinux.cmake | ||
| FindSqlite3.cmake | ||
| ThriftCppLibrary.cmake | ||